[Fix] Incomplete standalone images pass pre-merge checks - #1899
Open
roomote-roomote[bot] wants to merge 3 commits into
Open
[Fix] Incomplete standalone images pass pre-merge checks#1899roomote-roomote[bot] wants to merge 3 commits into
roomote-roomote[bot] wants to merge 3 commits into
Conversation
Contributor
|
No code issues found. See task
Reviewed 033587d |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 30, 2026 23:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
PR #1898 fixed the incomplete standalone image, and the subsequent publish and deployment-acceptance workflow passed. The same defect could still recur undetected because pull-request CI only built the image; it did not load the externalized server packages that failed on the first request.
Impact
Incomplete standalone images now fail during pull-request Docker Build instead of after merge during deployment acceptance. A clean production web build, equivalent ESM/CJS-aware resolution of all six configured externals, web typecheck, web lint, and the full pre-push suite passed. The sandbox does not expose a Docker socket, so the pull-request Docker Build is the final check of the new image-layer command.