Session detail tweaks#1329
Merged
Merged
Conversation
✅ Deploy Preview for antenna-ssec ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for antenna-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📝 WalkthroughWalkthroughThis PR removes the ChangesSnap-to-detections removal and session details redesign
Sequence DiagramsNo sequence diagrams generated. The changes primarily involve removing a setting flag, simplifying component contracts, and restructuring layout — patterns that do not meet the criteria for visualization (interactions are reduced rather than introduced, and the control flow is straightforward). Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/src/pages/session-details/process/process.tsx`:
- Around line 21-35: The Process component initializes pipelineId from async
project data but never updates it when project arrives; add a useEffect in
Process that watches project (or
project?.settings.defaultProcessingPipeline?.id) and calls
setPipelineId(project.settings.defaultProcessingPipeline.id) when a default
exists and pipelineId is not already set/overridden; reference the Process
component, the pipelineId state and setPipelineId, and useProjectDetails to
locate where to add the effect so the default pipeline is synced after async
load.
In `@ui/src/pages/session-details/session-details.tsx`:
- Around line 128-161: The mobile reading/focus order is wrong because the
sidebar Box uses CSS order-last; remove reliance on visual ordering and change
the JSX so the Box element appears in the DOM in the intended mobile reading
order (i.e., move the <Box className="order-last ..."> node to after the main
content in the JSX), then keep only the desktop reordering class (e.g., use
md:order-first on the Box) so desktop layout stays the same; update any
className references (remove order-last, keep md:order-first) and verify
components inside (Tabs.Root, Tabs.List, Tabs.Trigger, Tabs.Content,
SessionInfo, CaptureInfo, SessionPlots) remain unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cbfc3f63-b932-4eb5-a367-9173f1ba3af4
📒 Files selected for processing (4)
ui/src/pages/session-details/activity-plot/activity-plot.tsxui/src/pages/session-details/process/process.tsxui/src/pages/session-details/session-details.tsxui/src/pages/session-details/view-settings.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some follow up tweaks for #1327 .
List of Changes
Summary by CodeRabbit
Release Notes
Improvements
Style