MNT: Updates master with develop#1060
Open
Gui-FernandesBR wants to merge 9 commits into
Open
Conversation
Updates develop with master
BUG: Environment not Encoding Necessary Parameters for Decode
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1060 +/- ##
==========================================
+ Coverage 81.74% 81.84% +0.10%
==========================================
Files 118 115 -3
Lines 15248 15145 -103
==========================================
- Hits 12464 12396 -68
+ Misses 2784 2749 -35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 10, 2026
* ENH: seed sensor measurement noise per instance Sensor noise (Accelerometer, Gyroscope, Barometer, GnssReceiver) was drawn from the process-global NumPy RNG, so it could not be seeded or reproduced, and it was unsafe under parallel or forked execution where workers share or reset the global RNG (issue #1042). Thread an optional seed argument through the Sensor base classes. Each sensor now owns a numpy.random.Generator from np.random.default_rng(seed) and draws its white noise and random walk from it instead of np.random. seed=None keeps the noise random but per-instance, so existing behaviour is unchanged unless a seed is given. Also adds tests/unit/sensors/test_sensor_seeding.py covering reproducibility, decorrelation across seeds, independence from the global RNG, and the GnssReceiver path. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> * DOC: add CHANGELOG entry for sensor noise seeding (#1052) Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> * TST: seed the noisy sensor fixtures instead of the global RNG Sensor noise now comes from each sensor's own Generator, so the autouse `_seed_rng` fixture that seeded the global `np.random` no longer made the noisy assertions deterministic; they would flake on CI. Pass `seed=42` to the noisy accelerometer, gyroscope, barometer, and gnss fixtures so their noise is reproducible through the new per-instance seeding, and drop the now-defunct `_seed_rng` fixture. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> * ENH: serialize the sensor seed and document it Address review feedback: document the seed argument in every sensor __init__ (this also fills in the name entry that was missing from Gyroscope's docstring), and carry seed through to_dict/from_dict so it survives serialization, including GnssReceiver's custom to_dict. from_dict reads it with data.get("seed") so dicts saved before this change still load, defaulting to None. Add serialization tests: the seed round-trips through the JSON encoder for every sensor type, and from_dict defaults the seed to None when the key is absent. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> * TST: cover sensor base-class validation and dunders Add tests for the argument-validation error paths (measurement range, orientation, vectorized inputs, export file_format) and the __repr__ / __call__ helpers on Sensor and InertialSensor. These paths were untested; with them rocketpy/sensors reaches full statement coverage. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> --------- Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
developback in sync withmasterahead of the v1.13.0 tag.Content included:
Why merge this before tagging v1.13.0
The v1.13.0 changelog section (already on
mastervia #1048) lists #1059 under "Fixed", but the actual fix only landed ondevelopafter the release PR was merged. Merging this PR before creating the v1.13.0 tag makes the tag content match the changelog.🤖 Generated with Claude Code