fix(message-parser): keep URL underscores from closing link-text emphasis - #41731
fix(message-parser): keep URL underscores from closing link-text emphasis#41731AlgoArtist06 wants to merge 1 commit into
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: f4526e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe message parser now preserves underscores in Markdown link labels when the URL also contains underscores. A parser test covers the link syntax, and a patch changeset documents the fix. ChangesMessage parser link fix
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Cross-linking the other open PRs on #41725 so a maintainer does not have to untangle this:
Only one of these should land. Happy to close this one if either of the others is preferred. |
Proposed changes (including videos or screenshots)
Prevents an unmatched underscore in Markdown link text from treating an underscore in the URL as its emphasis closer.
Adds the exact reported regression case and a patch changeset for
@rocket.chat/message-parser.Keeps the change scoped to the message parser.
Issue(s)
Fixes #41725
Related to #41727
Steps to test or reproduce
[test-with-a-text-containing-an_here](http://example.com?param=my_value)in a channel.test-with-a-text-containing-an_hereis displayed and the whole label links tohttp://example.com?param=my_value.corepack yarn workspace @rocket.chat/message-parser test --runInBandwith Node 22.22.3.Further comments
Local verification:
The full Rocket.Chat monorepo test suite was not run because it is impractical for this focused parser change.
Summary by CodeRabbit
Bug Fixes
Tests