Skip to content

fix: restore Away status option on servers 8.6.0 and above#7498

Merged
Rohit3523 merged 3 commits into
developfrom
fix/restore-away-status-option
Jul 17, 2026
Merged

fix: restore Away status option on servers 8.6.0 and above#7498
Rohit3523 merged 3 commits into
developfrom
fix/restore-away-status-option

Conversation

@Rohit3523

@Rohit3523 Rohit3523 commented Jul 16, 2026

Copy link
Copy Markdown
Member

Proposed changes

We previously removed the "Away" status option from the Edit Status screen on servers >= 8.6.0. This reverses that change so the Away option is always available regardless of server version.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-2431

How to test or reproduce

  1. Connect to a server >= 8.6.0.
  2. Open Edit Status (profile → status).
  3. The "Away" option should now be visible even when the current status is online/busy/offline.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

The test should hide away option on server >= 8.6.0 when user is not away / ...when user is away was collapsed into a single should always show away option regardless of server version test reflecting the reverted behavior.

Summary by CodeRabbit

Summary by CodeRabbit

  • Bug Fixes
    • The “Away” status option is now consistently available in the status selector, regardless of server version or the user’s current status.
  • Tests
    • Updated the StatusView test coverage to reflect the new, always-visible “Away” option behavior.

Reverts the conditional hiding of the Away option in the Edit Status screen so it is always available regardless of server version.
@Rohit3523
Rohit3523 temporarily deployed to approve_e2e_testing July 16, 2026 12:40 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e8aa0004-9cc4-4b98-92d9-87083c255ad4

📥 Commits

Reviewing files that changed from the base of the PR and between 0484148 and b368d28.

📒 Files selected for processing (1)
  • app/views/StatusView/index.test.tsx
💤 Files with no reviewable changes (1)
  • app/views/StatusView/index.test.tsx
📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: ESLint and Test / run-eslint-and-test

Walkthrough

StatusView no longer conditionally hides the away status option. Its test suite now verifies that the option is always rendered.

Changes

StatusView away status

Layer / File(s) Summary
Always show away status
app/views/StatusView/index.tsx, app/views/StatusView/index.test.tsx
The status filter no longer excludes away based on expiry support or current status, and tests verify that the away option is displayed.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested labels: type: bug

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: restoring the Away status option on supported servers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • CORE-2431: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Rohit3523 Rohit3523 changed the title fix: restore Away status option on servers >= 8.6.0 fix: restore Away status option on servers 8.6.0 and above Jul 16, 2026
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

iOS Build Available

Rocket.Chat 4.75.0.109374

Comment thread app/views/StatusView/index.test.tsx Outdated
@Rohit3523
Rohit3523 requested a deployment to approve_e2e_testing July 17, 2026 12:12 — with GitHub Actions Waiting
@Rohit3523
Rohit3523 merged commit 1d9b5cc into develop Jul 17, 2026
5 of 8 checks passed
@Rohit3523
Rohit3523 deleted the fix/restore-away-status-option branch July 17, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants