fix: restore Away status option on servers 8.6.0 and above#7498
Conversation
Reverts the conditional hiding of the Away option in the Edit Status screen so it is always available regardless of server version.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
WalkthroughStatusView no longer conditionally hides the away status option. Its test suite now verifies that the option is always rendered. ChangesStatusView away status
Estimated code review effort: 2 (Simple) | ~5 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Android Build Available Rocket.Chat 4.75.0.109375 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNSacwvjyfmhTi40FTyc29FmyX295gKuj5o7QanZiVCoHPLSx5HLLG--0IakzURRe-S1hSWCiBQme61S73xw |
|
iOS Build Available Rocket.Chat 4.75.0.109374 |
Proposed changes
We previously removed the "Away" status option from the Edit Status screen on servers
>= 8.6.0. This reverses that change so the Away option is always available regardless of server version.Issue(s)
https://rocketchat.atlassian.net/browse/CORE-2431
How to test or reproduce
>= 8.6.0.Screenshots
Types of changes
Checklist
Further comments
The test
should hide away option on server >= 8.6.0 when user is not away/...when user is awaywas collapsed into a singleshould always show away option regardless of server versiontest reflecting the reverted behavior.Summary by CodeRabbit
Summary by CodeRabbit