fix(ios): pass RocketChat scheme to run-ios#7355
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe ChangesiOS Build Scheme Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed changes
Adds the
--scheme RocketChatargument to therun-ioscommand so React Native CLI launches the correct Xcode scheme when running:Without explicitly specifying the scheme, the CLI attempts to use
RocketChatRN, which no longer exists after the removal ofRocketChatRN.xcscheme.regression introduced in #7322
Issue(s)
https://rocketchat.atlassian.net/browse/COMM-171
How to test or reproduce
Screenshots
N/A
Types of changes
Checklist
Further comments
Summary by CodeRabbit