Skip to content

fix(ios): pass RocketChat scheme to run-ios#7355

Open
divyanshu-patil wants to merge 2 commits into
RocketChat:developfrom
divyanshu-patil:regression/missing-scheme
Open

fix(ios): pass RocketChat scheme to run-ios#7355
divyanshu-patil wants to merge 2 commits into
RocketChat:developfrom
divyanshu-patil:regression/missing-scheme

Conversation

@divyanshu-patil
Copy link
Copy Markdown

@divyanshu-patil divyanshu-patil commented May 28, 2026

Proposed changes

Adds the --scheme RocketChat argument to the run-ios command so React Native CLI launches the correct Xcode scheme when running:

pnpm run ios

Without explicitly specifying the scheme, the CLI attempts to use RocketChatRN, which no longer exists after the removal of RocketChatRN.xcscheme.

regression introduced in #7322

Issue(s)

https://rocketchat.atlassian.net/browse/COMM-171

How to test or reproduce

  1. clone develop branch
  2. run: pnpm run ios

Screenshots

N/A

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Bug Fixes
    • Updated iOS build configuration to explicitly specify the correct build scheme, ensuring more consistent iOS builds across environments. This reduces intermittent build failures and improves reliability for developers running or automating iOS builds, leading to smoother local testing and CI workflows.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e35f8440-8c7c-4d75-9767-bc343ed20cf0

📥 Commits

Reviewing files that changed from the base of the PR and between 22522b3 and 0f0b2f0.

📒 Files selected for processing (1)
  • package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

Walkthrough

The ios npm script in package.json is updated to explicitly pass the --scheme RocketChat argument to the React Native iOS build command, ensuring the correct Xcode scheme is selected during development builds.

Changes

iOS Build Scheme Configuration

Layer / File(s) Summary
React Native iOS build scheme
package.json
The ios npm script now explicitly specifies --scheme RocketChat when running React Native iOS builds, replacing the implicit default behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

type: bug

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: passing the RocketChat scheme argument to the iOS run command, which is the core fix for the regression.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • COMM-171: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@divyanshu-patil divyanshu-patil changed the title regression: specified scheme while building iOS application regression: error missing scheme RocketChatRN while running pnpm run ios May 28, 2026
@Rohit3523 Rohit3523 changed the title regression: error missing scheme RocketChatRN while running pnpm run ios fix(ios): pass RocketChat scheme to run-ios Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants