Skip to content

Fix idempotency key default value handling in LedgerClient #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfrench9 merged 1 commit into from
Apr 16, 2026
+3 −2
Merged

Fix idempotency key default value handling in LedgerClient #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion robosystems_client/clients/ledger_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,7 +1027,7 @@ def create_journal_entry(
graph_id=graph_id,
body=body,
client=self._get_client(),
idempotency_key=idempotency_key,
idempotency_key=idempotency_key if idempotency_key is not None else UNSET,
)
envelope = self._call_op("Create journal entry", response)
return envelope.result or {}
Expand Down
3 changes: 2 additions & 1 deletion tests/test_ledger_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from robosystems_client.clients.ledger_client import LedgerClient
from robosystems_client.models.operation_envelope import OperationEnvelope
from robosystems_client.models.operation_envelope_status import OperationEnvelopeStatus
from robosystems_client.types import UNSET


# ── Helpers ────────────────────────────────────────────────────────────
Expand Down Expand Up @@ -442,7 +443,7 @@ def test_create_journal_entry_basic(self, mock_op, mock_config, graph_id):
assert result["status"] == "draft"
call_kwargs = mock_op.call_args.kwargs
assert call_kwargs["graph_id"] == graph_id
assert call_kwargs["idempotency_key"] is None
assert call_kwargs["idempotency_key"] is UNSET
body = call_kwargs["body"]
assert body.memo == "Q1 revenue"
assert len(body.line_items) == 2
Expand Down
Loading