Stop pointing camera bring-up at the motion-enabling profile - #229
Merged
Conversation
The bring-up steps contradicted themselves. Step 1 has the operator stop motion and confirm the servo rail and torque are off; step 2 then told them to flash stackchan_camera_probe for a private image, and that profile sets STACKCHAN_MOTION_ENABLED_AT_BOOT=1 and STACKCHAN_AUTONOMOUS_MOTION_AT_BOOT=1. Following the instructions in order undid the safety step. Point the private path at stackchan_release_forensics_vision, which adds the camera and the authenticated host-vision endpoints while keeping the inherited motion-off-at-boot posture, and say plainly what the difference is. stackchan_camera_probe stays documented for when autonomous motion is itself the thing under test. Also record that every camera-enabled environment now refuses to build without a pairing code, so an unauthenticated camera image cannot be produced by forgetting one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bring-up steps in
docs/LOCAL_VISION.mdcontradicted themselves:stackchan_camera_probefor a private token-enabled OTA lab image.stackchan_camera_probesetsSTACKCHAN_MOTION_ENABLED_AT_BOOT=1andSTACKCHAN_AUTONOMOUS_MOTION_AT_BOOT=1. Following the instructions in order undoes the safety step you were just told to perform.Now points the private path at
stackchan_release_forensics_vision(added in #224), which takes the camera and the authenticated host-vision endpoints while keeping the inherited motion-off-at-boot posture, and states the difference between the two profiles plainly rather than leaving it to be discovered fromplatformio.ini.stackchan_camera_probestays documented for when autonomous motion is itself what you are testing — it is not deprecated, just no longer the default suggestion for vision work.Also records that every camera-enabled environment refuses to build without
STACKCHAN_PAIRING_SHORT_CODE, so an unauthenticated camera image cannot be produced by forgetting one.Documentation only.