Expose the audio terminal deferral counter - #227
Merged
Conversation
#221 added terminalAudioDeferrals to the uplink telemetry but never exported it, so the counter that shows the End-terminal hold engaging was unreadable from the robot. During that PR's physical qualification /debug returned nothing for it, and the evidence could only state the narrower claim: the audio_count_mismatch failure did not recur, and terminal delivery was never harmed. Distinguishing "the hold worked" from "the race did not happen to trigger" needs the counter. Export it in /debug alongside the existing terminal retry and timeout counters, and on the serial status line with them. Telemetry only; no behaviour change. pio test -e native_logic: 316/316. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#221 added
terminalAudioDeferralsto the uplink telemetry but never exported it, so the counter that shows the End-terminal hold engaging was unreadable from the robot.That gap has a concrete cost. During #221's physical qualification
/debugreturned nothing for it, so the evidence could only support the narrower claim: theaudio_count_mismatchfailure did not recur across three utterances, and terminal delivery was never harmed (0 timeouts, 0 retries). Distinguishing the hold worked from the race did not happen to trigger needs the counter.Exported in
/debugalongside the existingbridge_uplink_terminal_retriesandbridge_uplink_terminal_timeouts, and on the serial status line with them.Telemetry only; no behaviour change.
pio test -e native_logic: 316/316.Worth flashing together with #224's vision profile rather than on its own — the next supervised run then reports both whether the hold engages and whether host vision advances.