Avoid goroutine fan-out in SumBigValues - #552
Open
perfloop-agent wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoids creating a goroutine for every bit slice in
roaring64.BSI.SumBigValues.Type of Change
Changes Made
What was changed?
big.Intterm.Why was it changed?
How was it changed?
Testing
go test ./...Checks: 3 passed.
Formatting
gofmt -s -lreports no files.Fuzzing
Not run; this only changes aggregate arithmetic and scheduling.
Performance Impact
The benchmark uses a 63-bit BSI with 128 values. The traversal is intentionally serial, favoring small per-bit intersections over per-bit scheduling.
Workload:
SumBigValues on a 63-bit BSI with 128 valuesns/opB/opallocs/opRunning Benchmarks
go test ./roaring64 -run '^$' -bench '^BenchmarkBSI64SumBigValues$' -benchmemPerformance Analysis
Reusing the term avoids building a result channel and a separate
big.Intfor each bit plane.Breaking Changes
None.
Related Issues
None.
Additional Notes
None.
Generated by Perfloop. Measurements and checks.