Skip to content

fix: invalid treemap iter advance - #360

Open
silver-ymz wants to merge 1 commit into
RoaringBitmap:mainfrom
silver-ymz:fix/treemap-iter-advance-across-bitmaps
Open

fix: invalid treemap iter advance#360
silver-ymz wants to merge 1 commit into
RoaringBitmap:mainfrom
silver-ymz:fix/treemap-iter-advance-across-bitmaps

Conversation

@silver-ymz

Copy link
Copy Markdown

The PR fixes following cases:

  • After calling next(), jump forward 32 bits in the bitmap.
  • After calling next_back(), jump backward in the bitmap.
  • When the target bitmap does not exist, do not apply the invalid target's lower 32 bits to the next bitmap.
  • Symmetric backward missing bitmap situation.

You can review the test cases for detailed information about these bugs.

Signed-off-by: Mingzhuo Yin <yinmingzhuo@gmail.com>
@silver-ymz

Copy link
Copy Markdown
Author

@Kerollmops Could you help to review it? Thank you very much!

@Kerollmops

Copy link
Copy Markdown
Member

Hey @silver-ymz 👋

Thanks for the bug report and fix. Would it be possible to create two commits: one with the tests you added and another with the fix itself. Can you push them one after the other so that I can see the CI breaking on your first commit (the next tests failing) and the other become green as it fixes the tests, please?

Have a nice day 🌵

@Kerollmops Kerollmops self-assigned this Aug 3, 2026
@silver-ymz

Copy link
Copy Markdown
Author

cargo clippy failed due to a rust version update and is unrelated to this PR. It seems we need to first make clippy happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants