fix: invalid treemap iter advance - #360
Open
silver-ymz wants to merge 1 commit into
Open
Conversation
Signed-off-by: Mingzhuo Yin <yinmingzhuo@gmail.com>
Author
|
@Kerollmops Could you help to review it? Thank you very much! |
Member
|
Hey @silver-ymz 👋 Thanks for the bug report and fix. Would it be possible to create two commits: one with the tests you added and another with the fix itself. Can you push them one after the other so that I can see the CI breaking on your first commit (the next tests failing) and the other become green as it fixes the tests, please? Have a nice day 🌵 |
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes following cases:
You can review the test cases for detailed information about these bugs.