Attribute Select: read attributes from Roam's new attributes model - #538
Open
panterarocks49 wants to merge 1 commit into
Open
Attribute Select: read attributes from Roam's new attributes model#538panterarocks49 wants to merge 1 commit into
panterarocks49 wants to merge 1 commit into
Conversation
Roam's attributes revamp replaces :entity/attrs and :attrs/lookup with harc entities, and the migration retracts the old data. The attribute list query in the config panel now reads attribute pages off :harc/a. Claude-Session: https://claude.ai/code/session_01R2JbnyYCXWKHUQxh2FLZbn
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roam's upcoming attributes revamp replaces
:entity/attrs/:attrs/lookupwith harc entities, and the migration retracts the old data, so the attribute list query in the Attribute Select config panel comes back empty. This swaps it for the one-clause equivalent on the new model:Same result shape, so the surrounding code is untouched. Bumps to 1.8.3 with a changelog entry.
Tested end to end in a Roam dev build on the new model: "Add Attribute" lists the graph's attributes, the dropdown renders next to
Attr::blocks, and selecting a value rewrites the block. Proxy attributes (roam/meta, opt-in proxies) never create harcs, so they no longer appear in the list, which is fine for a value picker.Please hold the release until the Roam release that ships the new model is out; before that the list would be empty for hosted graphs.
https://claude.ai/code/session_01R2JbnyYCXWKHUQxh2FLZbn