merge upstream changes#7
Draft
cebarks wants to merge 16 commits into
Draft
Conversation
…FilePath Add SteamInput's SetInputActionManifestFilePath
Fix function used for Friends.ActivateGameOverlayToStore
…iolation error. This is a janky fix, but it gets this working again with SDK 162. First change is an early return after checking isInitSuccess. Not ideal, but it prevents the access violation error when the appid is not present in the persons library. Other change is to comment out deprecated RequestCurrentStats(); call. Unclear to me if line 1066 should remain.
Fixes basic compatibility with Steamworks SDK 162, and fixes access v…
Implement functions to handle UGC queries and retrieve results.
Add support for querying Steam Workshop items
fix directory for steam files, which are required in library (with current linux command)
…luded in the original
add GetAppDependencies and DownloadItem to the workshop interface
Support Nuitka `--onefile` compiled application; Implement ISteamUGC/GetAppDependencies (resubmit of philippj#91)
Update README.md
Combines RimSort fork features (_libs path param, SWPY_PATH env var, cstdint include, Mac compile fixes) with upstream additions (SteamInput SetInputActionManifestFilePath, UGC query support, SDK 162 compatibility, GetAppDependenciesResult_t, DownloadItem). Resolves duplicate GetAppDependenciesResult struct and duplicate SetGetAppDependenciesResultCallback method from independent implementations on both sides. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The fork and upstream independently implemented GetAppDependencies, leaving duplicate members, methods, and exported functions after merge. Removes the fork's implementations in favor of upstream's, which passes GetAppDependenciesResult_t directly instead of copying into a custom struct. - Remove fork's GetAppDependenciesResult custom C++ struct - Remove duplicate class members, methods, and exported C functions - Remove fork's SetGetAppDependenciesResultCallback (use upstream's SetGetAppDependenciesCallback) - Add _pack_=4 and _layout_="ms" to GetAppDependenciesResult_t for correct struct alignment with SDK 164 - Add get_app_dependencies_list() helper to GetAppDependenciesResult_t - Update methods.py argtype to use GetAppDependenciesResult_t Tested: compiles clean against SDK 164 on arm64 macOS, live Steam client test confirms correct pfid values and callback delivery. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges upstream changes from twstagg/SteamworksPy into the RimSort fork, bringing in bug fixes, new API bindings, and SDK compatibility improvements.
Upstream changes included
RequestCurrentStats()call (Fixes basic compatibility with Steamworks SDK 162, and fixes access v… philippj/SteamworksPy#109)SetInputActionManifestFilePath— new binding for setting the input action manifest file path (Add SteamInput's SetInputActionManifestFilePath philippj/SteamworksPy#89)CreateQueryUGCDetailsRequest,SendQueryUGCRequest,GetQueryUGCResult, and associated callback/struct types for querying Steam Workshop item details (Add support for querying Steam Workshop items philippj/SteamworksPy#110)GetAppDependenciesandDownloadItem— new Workshop interface methods withGetAppDependenciesResult_tandDownloadItemResult_tstructs (add GetAppDependencies and DownloadItem to the workshop interface philippj/SteamworksPy#115)--onefilesupport — compiled application compatibility (Support Nuitka--onefilecompiled application; Implement ISteamUGC/GetAppDependencies (resubmit of #91) philippj/SteamworksPy#114)Friends.ActivateGameOverlayToStore— corrected function link (Fix function used for Friends.ActivateGameOverlayToStore philippj/SteamworksPy#105)Conflict resolution
Both the fork and upstream independently implemented some of the same features (Nuitka support,
GetAppDependencies). Conflicts were resolved by:_libspath parameter andSWPY_PATHenv var support (not present upstream)GetAppDependenciesResult_t,DownloadItemResult_t)