test(delivery): deflake TestUnreadableOwedMentionClearedNotReswept — gate on waitForOwed not post-drain owedCount (RIG-2920) - #718
Open
rigel-mintaka wants to merge 3 commits into
Conversation
…gate on waitForOwed not post-drain owedCount (RIG-2920) The unreadable-owed clear is a side-effect of the start-edge sweep, which runs after waitStartsDrained returns (that helper only proves the edge was dequeued, per introspect_test.go). Asserting owedCount==0 right after it raced the async sweep and flaked red under CI load (owed rows = 1, want 0). Gate on the existing waitForOwed(t, recipient, 0) barrier, which polls until the clear lands and t.Fatalf's at the deadline otherwise — deterministic, strictly stronger. Test-only; no production code touched. Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Compass engineering docs preview: https://compass-comms-rig-2920-defla.compass-eng-docs.pages.dev Deployed from |
… site (RIG-2920) Review low: the helper's doc scoped it to the nil-waker case, but the deflake adds a caller where owed->0 is the sweep's clear side-effect with a dispatcher present. Broaden the doc so it covers both call sites. Co-authored-by: Matt Wilkinson <matt@rigel.build>
…RIG-2920) Round-2 review low: the doc names two representative callers but the helper has four (all the same record -> owed-row shape). Signal the list is an example, not exhaustive; the leading general clause already covers all four. Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
marked this pull request as ready for review
August 28, 2026 05:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unreadable-owed clear is a side-effect of the start-edge sweep, which
runs after waitStartsDrained returns (that helper only proves the edge was
dequeued, per introspect_test.go). Asserting owedCount==0 right after it
raced the async sweep and flaked red under CI load (owed rows = 1, want 0).
Gate on the existing waitForOwed(t, recipient, 0) barrier, which polls until
the clear lands and t.Fatalf's at the deadline otherwise — deterministic,
strictly stronger. Test-only; no production code touched.
Co-authored-by: Matt Wilkinson matt@rigel.build