feat(renovate): auto-bump DefaultPostgresImage digest within postgres:18 (RIG-2774) - #673
Merged
Merged
Conversation
|
Compass engineering docs preview: https://dependencies-rig-2774-postgr.compass-eng-docs.pages.dev Deployed from |
rigel-mintaka
force-pushed
the
dependencies/rig-2774-postgres-digest
branch
from
August 27, 2026 05:08
4c8600f to
285d697
Compare
rigel-mintaka
marked this pull request as ready for review
August 27, 2026 05:15
…:18 (RIG-2774) Surface go/internal/stack/postgres_image.go's DefaultPostgresImage Go const as a docker dep via a custom.regex manager in tools/renovate/config.json5 so upstream postgres:18 security rebuilds (same major, new digest) flow through a reviewable PR instead of the pin silently rotting. DL-260 freezes the postgres MAJOR at 18 for on-disk-format stability, so a paired packageRule pins allowedVersions to /^18$/: the digest moves, an 18->19 major bump stays a deliberate design action (re-run the T8 podman integration test), never an auto-PR. Two conventions the file's shape forces: - depName is 'postgres-stack', NOT 'postgres': the CI-service disable fence (matchDepNames ['postgres'], enabled false) is unscoped by manager/file, so a 'postgres' depName would inherit the disable and open zero PRs. The distinct name keeps the two postgres pins independently governed; a last-match-wins replay test asserts postgres-stack resolves ENABLED while 'postgres' stays disabled. - versioningTemplate is explicit 'docker': a custom.regex manager defaults to semver-coerced regardless of datasource, which mishandles a <tag>@<digest> reference. The repo-wide 5-day minimumReleaseAge soak is kept: Docker Hub carries a tag_last_pushed timestamp for the digest, so a rebuild clears the window (no permanent-pending stall the git-refs channel dep needs nulled). config.test.ts gains a RIG-2774 block: manager shape, live regex extraction against the real Go file, the digest-only /^18$/ rule, and the fence- independence behavioral guard. Updates the const's bump-procedure comment to describe the automated digest path. Spec-impact: none Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
dependencies/rig-2774-postgres-digest
branch
from
August 27, 2026 19:05
285d697 to
34f7911
Compare
mattwilkinsonn
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 2 PRs:
mainSurface go/internal/stack/postgres_image.go's DefaultPostgresImage Go const
as a docker dep via a custom.regex manager in tools/renovate/config.json5 so
upstream postgres:18 security rebuilds (same major, new digest) flow through a
reviewable PR instead of the pin silently rotting.
DL-260 freezes the postgres MAJOR at 18 for on-disk-format stability, so a
paired packageRule pins allowedVersions to /^18$/: the digest moves, an 18->19
major bump stays a deliberate design action (re-run the T8 podman integration
test), never an auto-PR.
Two conventions the file's shape forces:
(matchDepNames ['postgres'], enabled false) is unscoped by manager/file, so a
'postgres' depName would inherit the disable and open zero PRs. The distinct
name keeps the two postgres pins independently governed; a last-match-wins
replay test asserts postgres-stack resolves ENABLED while 'postgres' stays
disabled.
semver-coerced regardless of datasource, which mishandles a @
reference.
The repo-wide 5-day minimumReleaseAge soak is kept: Docker Hub carries a
tag_last_pushed timestamp for the digest, so a rebuild clears the window (no
permanent-pending stall the git-refs channel dep needs nulled).
config.test.ts gains a RIG-2774 block: manager shape, live regex extraction
against the real Go file, the digest-only /^18$/ rule, and the fence-
independence behavioral guard. Updates the const's bump-procedure comment to
describe the automated digest path.
Spec-impact: none
Review disposition (sole review of record, 2 rounds)
matchAll+toHaveLength(1)(matches the file's catalog/devenv convention); digest-only rule gains a semanticallowedVersionscheck (accepts18, rejects19). Red-green verified both guards fail closed.config.test.ts) is a maintainability judgment call touching pre-existing test infra — DEFERRED to keep this PR single-purpose, filed as RIG-2838.Local validation:
moon run renovate:ci89 pass / 0 fail, typecheck clean, biome clean. Pre-push whole-repomoon cipassed on submit.