Squash Effect Cause before Sentry.captureException#522
Merged
RhysSullivan merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
Sentry's captureException can't extract an Error from an Effect Cause and logs a 'CauseImpl captured as exception' warning event instead of the underlying failure. Three call sites were passing a Cause directly: two catchCause handlers in mcp.ts/mcp-session.ts, and the unknown-typed helpers in error-response.ts that catchCause callers feed into. Squash to a real value for the exception payload and attach the pretty-printed cause as a 'cause' extra, matching the pattern already used in observability.ts.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 362c5ab | Commit Preview URL Branch Preview URL |
May 04 2026, 08:00 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 362c5ab | May 04 2026, 08:01 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/storage-core
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-google-discovery
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
captureExceptioncan't extract anErrorfrom an EffectCause, so it logs a'CauseImpl' captured as exception with keys: reasons, ~effect/Causeevent instead of the real failure.Causedirectly: thecatchCausehandlers inmcp.tsandmcp-session.ts, and theunknown-typed helpers inerror-response.tsthatcatchCausecallers inapi/autumn.tsandapi/slack.tsfeed into.Cause.pretty(...)as acauseextra, matching the pattern already used inobservability.ts.Test plan
POST /mcpand confirm Sentry shows the underlying failure (withcauseextra) rather than theCauseImpl captured as exceptionwarning./autumn/*or/slack/*and confirm the same.