[codex] add additional headers workflows to OpenAPI and GraphQL#350
Closed
heyglassy wants to merge 2 commits intoRhysSullivan:mainfrom
Closed
[codex] add additional headers workflows to OpenAPI and GraphQL#350heyglassy wants to merge 2 commits intoRhysSullivan:mainfrom
heyglassy wants to merge 2 commits intoRhysSullivan:mainfrom
Conversation
Map MCP OAuth session storage failures to McpOAuthError so auth-path backend failures surface a user-readable message instead of being translated into InternalError(traceId) at the HTTP edge. Cover the regression with a plugin test that forces oauth session lookup to fail and asserts the executor surface returns McpOAuthError with the storage message.
Extract the MCP plaintext additional-headers editor into a shared React plugin module and reuse it across MCP, GraphQL, and OpenAPI forms. Split stored header state into secret-backed authentication headers and plaintext additional headers for GraphQL and OpenAPI, merge them back into the existing header payload shape on save, and add validation for blank additional-header rows, duplicate header names, and OAuth-managed Authorization conflicts. Add focused Vitest coverage for the shared header helper plus mixed plaintext/secret-backed header persistence in the GraphQL and OpenAPI plugin tests.
Owner
|
Closing — superseded by main's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
headerspayloadAuthorizationconflictsWhy
OpenAPI and GraphQL previously lacked the separate plaintext additional-headers workflow that MCP already exposed, which made the header UX inconsistent and mixed plaintext headers into authentication flows.
Validation
bunx vitest run packages/react/src/plugins/additional-headers.test.tsbunx vitest run packages/plugins/graphql/src/sdk/plugin.test.tsbunx vitest run packages/plugins/openapi/src/sdk/plugin.test.ts