[codex] enforce unique secret ids client-side in web UI#347
Open
heyglassy wants to merge 1 commit intoRhysSullivan:mainfrom
Open
[codex] enforce unique secret ids client-side in web UI#347heyglassy wants to merge 1 commit intoRhysSullivan:mainfrom
heyglassy wants to merge 1 commit intoRhysSullivan:mainfrom
Conversation
heyglassy
force-pushed
the
codex/ui-secret-id-uniqueness
branch
3 times, most recently
from
1dc4677 to
00da213
Compare
Keep secret ID uniqueness enforcement in the web UI only and preserve the existing upsert behavior in the core secrets API. Prefill source and secrets-page creation flows with the first available unique ID, prevent duplicate manual IDs in the shared React flows, and show each saved secret's ID beside its name in the secrets list with subdued monospace styling and a themed hover tooltip for the full value. Add an optional hideArrow escape hatch to the shared tooltip component so the secrets list can keep that tooltip flush with the dark UI.
heyglassy
force-pushed
the
codex/ui-secret-id-uniqueness
branch
from
00da213 to
6b06979
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
-2,-3, etc. suffixWhy
Creating secrets from web source flows could prefill IDs that collided with existing secrets, and the UI would allow the duplicate through because
secrets.setis still an upsert. This keeps the API/core contract unchanged and makes the web UI pick a unique default and block obvious collisions before submit.Validation
bun run --filter @executor/react typecheckbun run --filter @executor/plugin-openapi typecheckbun run --filter @executor/plugin-google-discovery typecheckbunx vitest run --config vitest.config.ts src/plugins/secret-id.test.ts(frompackages/react)