Align USD texture offset on even rows with s25client#48
Draft
morganchristiansson wants to merge 6 commits into
Draft
Align USD texture offset on even rows with s25client#48morganchristiansson wants to merge 6 commits into
morganchristiansson wants to merge 6 commits into
Conversation
morganchristiansson
force-pushed
the
align-coords
branch
from
8501b0f to
ecd7dc1
Compare
Contributor
Author
|
SIMPLE EXPLANATION: Bruh this hex coordinate system and AI trying to explain it and reason about it is doing my noggin. Having different coordinate systems and trying to share and reuse code between them is insanity. |
morganchristiansson
force-pushed
the
align-coords
branch
from
12dc570 to
a325088
Compare
morganchristiansson
changed the title
morganchristiansson
force-pushed
the
align-coords
branch
from
a325088 to
3784724
Compare
Contributor
Author
|
I've lost the thread on this PR. Will close it for now. |
morganchristiansson
force-pushed
the
align-coords
branch
from
3784724 to
7320c45
Compare
Contributor
Author
|
I managed to wrap my head around this again and narrow in on the actual code differences. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s25edit uses different coordinate offsets forUSD triangles than s25client for no good reason.
Switch to s25client coordinate system.
Adds Geometry.h with clientUsdX() noop wrapper to mark converted. Will affect other PRs&branches using coordinates.
Includes #40 as base branch, when that is merged it will disappear from this diff.