Skip to content

RE1-T112 Fixes#325

Merged
ucswift merged 1 commit intomasterfrom
develop
Apr 11, 2026
Merged

RE1-T112 Fixes#325
ucswift merged 1 commit intomasterfrom
develop

Conversation

@ucswift
Copy link
Copy Markdown
Member

@ucswift ucswift commented Apr 11, 2026

Summary by CodeRabbit

  • Refactor
    • Updated Dispatch Dashboard, Mapping, and Shifts pages to enable conditional loading of Angular resources.
    • Modified shared layout to load Angular stylesheets and scripts only when needed by the active page.

@request-info
Copy link
Copy Markdown

request-info bot commented Apr 11, 2026

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a6f86539-df29-4c11-8e63-b12509e22156

📥 Commits

Reviewing files that changed from the base of the PR and between db6c18f and 1c2112b.

📒 Files selected for processing (4)
  • Web/Resgrid.Web/Areas/User/Views/Dispatch/Dashboard.cshtml
  • Web/Resgrid.Web/Areas/User/Views/Mapping/Index.cshtml
  • Web/Resgrid.Web/Areas/User/Views/Shared/_UserLayout.cshtml
  • Web/Resgrid.Web/Areas/User/Views/Shifts/Index.cshtml

📝 Walkthrough

Walkthrough

Three views now set ViewBag.LoadAngular = true to signal Angular resource loading. The shared layout conditionally includes Angular stylesheets and scripts only when this flag is enabled, deferring Angular resource inclusion to views that require it.

Changes

Cohort / File(s) Summary
Views Setting Angular Flag
Web/Resgrid.Web/Areas/User/Views/Dispatch/Dashboard.cshtml, Web/Resgrid.Web/Areas/User/Views/Mapping/Index.cshtml, Web/Resgrid.Web/Areas/User/Views/Shifts/Index.cshtml
Each view added ViewBag.LoadAngular = true to enable conditional Angular resource loading via the shared layout.
Shared Layout Conditional Resources
Web/Resgrid.Web/Areas/User/Views/Shared/_UserLayout.cshtml
Added conditional rendering blocks gated by ViewBag.LoadAngular == true wrapping Angular stylesheets (styles.css, Google Material Icons) and Angular scripts (app.js for Release/Staging/Production/Docker; runtime.js, polyfills.js, vendor.js, main.js for Development).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • RE1-T112 Bug fixes #322: Modifies Views/Shifts/Index.cshtml for asset-loading behavior changes; both PRs target the same view's Angular resource initialization pattern.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'RE1-T112 Fixes' is vague and does not convey meaningful information about what was actually changed. It references a ticket number but provides no context about the specific changes (conditional Angular loading across multiple views). Revise the title to describe the main change, such as 'Conditionally load Angular resources only on required pages' or 'Add ViewBag flag for selective Angular loading'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ucswift
Copy link
Copy Markdown
Member Author

ucswift commented Apr 11, 2026

Approve

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit a5e17a2 into master Apr 11, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant