RE1-T112 fixes

[ucswift]

Summary by CodeRabbit

• Bug Fixes

  • Enhanced loading bar error handling to prevent the UI from remaining stuck in the loading state during errors.

• Chores

  • Updated payment checkout and processing workflow exemptions.

[request-info]

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

[coderabbitai]

📝 Walkthrough

Walkthrough

Two changes to the Resgrid web application: (1) adds client-side error handling to wrap Pace.bar.finish, catching exceptions and updating CSS classes to prevent propagation, and (2) expands the RequireActivePlanFilter exempt action list with two Paddle-related actions to bypass paid plan enforcement.

Changes

Cohort / File(s)	Summary
Client-side Pace Error Handling Web/Resgrid.Web/Areas/User/Views/Shared/_UserLayout.cshtml	Adds an inline script that conditionally wraps Pace.bar.finish to catch exceptions, removes pace-running class and adds pace-done when errors occur, preventing exception propagation.
Filter Exemptions Web/Resgrid.Web/Filters/RequireActivePlanFilter.cs	Adds getpaddlecheckout and paddleprocessing actions to the exempt action list, allowing these actions to bypass active paid plan enforcement.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'RE1-T112 fixes' is vague and generic, using only a ticket reference without describing the actual changes made.	Provide a more descriptive title that explains what is being fixed, such as 'Fix Pace progress bar error handling and add paddle checkout exemptions'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Web/Resgrid.Web/Filters/RequireActivePlanFilter.cs`:
- Around line 35-37: The current global action-name exemptions (e.g.,
"GetPaddleCheckout", "PaddleProcessing", "stripebillinginfoupdatesuccess") in
RequireActivePlanFilter allow any controller with those action names to bypass
plan checks; change the exemption mechanism to check both controller and action
names (controller+action pair) instead of action-only. Update
RequireActivePlanFilter (the filter method that reads
ActionDescriptor/RouteValues and the exemption list) to store allowed exemptions
as explicit (controller, action) pairs and perform matching using
context.ActionDescriptor.RouteValues["controller"] and ["action"] (or the
filterContext equivalents) so only the intended controller/action combinations
are exempted. Ensure existing single-action checks are replaced/augmented
accordingly and update any unit tests referencing the old action-only
exemptions.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 176dec48-d8e4-409a-8756-f1d8c13e88f2

📥 Commits

Reviewing files that changed from the base of the PR and between 5e6ff9a and f01eee6.

📒 Files selected for processing (2)

• Web/Resgrid.Web/Areas/User/Views/Shared/_UserLayout.cshtml
• Web/Resgrid.Web/Filters/RequireActivePlanFilter.cs

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Scope exemption by controller+action to avoid unintended plan-bypass expansion.

Adding these action-name exemptions globally means any User-area action named GetPaddleCheckout or PaddleProcessing in other controllers will bypass plan enforcement. Please constrain exemptions to explicit controller/action pairs (or endpoint metadata) so this remains narrowly targeted.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Web/Resgrid.Web/Filters/RequireActivePlanFilter.cs` around lines 35 - 37, The
current global action-name exemptions (e.g., "GetPaddleCheckout",
"PaddleProcessing", "stripebillinginfoupdatesuccess") in RequireActivePlanFilter
allow any controller with those action names to bypass plan checks; change the
exemption mechanism to check both controller and action names (controller+action
pair) instead of action-only. Update RequireActivePlanFilter (the filter method
that reads ActionDescriptor/RouteValues and the exemption list) to store allowed
exemptions as explicit (controller, action) pairs and perform matching using
context.ActionDescriptor.RouteValues["controller"] and ["action"] (or the
filterContext equivalents) so only the intended controller/action combinations
are exempted. Ensure existing single-action checks are replaced/augmented
accordingly and update any unit tests referencing the old action-only
exemptions.

[ucswift]

Approve

[github-actions]

This PR is approved.