Fix AES-256 key unwrap: select ECB cipher from master key length#43
Open
weiherelationalai wants to merge 2 commits into
Open
Fix AES-256 key unwrap: select ECB cipher from master key length#43weiherelationalai wants to merge 2 commits into
weiherelationalai wants to merge 2 commits into
Conversation
Production Snowflake stages can return a 32-byte queryStageMasterKey. The previous encrypt_aes_128_ecb / decrypt_aes_128_ecb functions hardcoded aes_128_ecb (16-byte key only) and returned "Invalid key size" for any 32-byte master key. Replace with encrypt_aes_ecb / decrypt_aes_ecb that select aes_128_ecb for 16-byte keys and aes_256_ecb for 32-byte keys, matching the Snowflake CSE protocol. Also compute key_size in MaterialDescription from the actual decoded key length instead of hardcoding "128". Both S3 and Azure KMS paths are updated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
metrics 0.23.0 uses an unsafe lifetime extension in recorder/mod.rs that a recent Rust compiler update (rust-lang/rust#141402) now rejects with E0521. 0.23.1 is the patch release that fixes it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production Snowflake stages can return a 32-byte queryStageMasterKey. The previous encrypt_aes_128_ecb / decrypt_aes_128_ecb functions hardcoded aes_128_ecb (16-byte key only) and returned "Invalid key size" for any 32-byte master key.
Replace with encrypt_aes_ecb / decrypt_aes_ecb that select aes_128_ecb for 16-byte keys and aes_256_ecb for 32-byte keys, matching the Snowflake CSE protocol. Also compute key_size in MaterialDescription from the actual decoded key length instead of hardcoding "128".
Both S3 and Azure KMS paths are updated.