Skip to content

Fix default value for CSV compression option #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidwzhao merged 3 commits into from
Jun 15, 2026
Merged

Fix default value for CSV compression option #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
465401e
Fix default csv compression value
davidwzhao Jun 12, 2026
c19a8da
Update generated parsers
davidwzhao Jun 12, 2026
9a49792
Update test snapshots
davidwzhao Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion meta/src/meta/grammar.y
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1488,7 +1488,7 @@ def construct_csv_config(
missing_strings: Sequence[String] = _extract_value_string_list(builtin.dict_get(config, "csv_missing_strings"), list[str]())
decimal_separator: str = _extract_value_string(builtin.dict_get(config, "csv_decimal_separator"), ".")
encoding: str = _extract_value_string(builtin.dict_get(config, "csv_encoding"), "utf-8")
compression: str = _extract_value_string(builtin.dict_get(config, "csv_compression"), "auto")
compression: str = _extract_value_string(builtin.dict_get(config, "csv_compression"), "")
partition_size_mb: int = _extract_value_int64(builtin.dict_get(config, "csv_partition_size_mb"), 0)
storage_integration: Optional[logic.StorageIntegration] = construct_csv_storage_integration(storage_integration_opt)
return logic.CSVConfig(
Expand Down
2 changes: 1 addition & 1 deletion sdks/go/src/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,7 @@ func (p *Parser) construct_csv_config(config_dict [][]interface{}, storage_integ
decimal_separator := _t2118
_t2119 := p._extract_value_string(dictGetValue(config, "csv_encoding"), "utf-8")
encoding := _t2119
_t2120 := p._extract_value_string(dictGetValue(config, "csv_compression"), "auto")
_t2120 := p._extract_value_string(dictGetValue(config, "csv_compression"), "")
compression := _t2120
_t2121 := p._extract_value_int64(dictGetValue(config, "csv_partition_size_mb"), 0)
partition_size_mb := _t2121
Expand Down
2 changes: 1 addition & 1 deletion sdks/julia/LogicalQueryProtocol.jl/src/parser.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ function construct_csv_config(parser::ParserState, config_dict::Vector{Tuple{Str
decimal_separator = _t2105
_t2106 = _extract_value_string(parser, get(config, "csv_encoding", nothing), "utf-8")
encoding = _t2106
_t2107 = _extract_value_string(parser, get(config, "csv_compression", nothing), "auto")
_t2107 = _extract_value_string(parser, get(config, "csv_compression", nothing), "")
compression = _t2107
_t2108 = _extract_value_int64(parser, get(config, "csv_partition_size_mb", nothing), 0)
partition_size_mb = _t2108
Expand Down
2 changes: 1 addition & 1 deletion sdks/python/src/lqp/gen/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ def construct_csv_config(self, config_dict: Sequence[tuple[str, logic_pb2.Value]
decimal_separator = _t2114
_t2115 = self._extract_value_string(config.get("csv_encoding"), "utf-8")
encoding = _t2115
_t2116 = self._extract_value_string(config.get("csv_compression"), "auto")
_t2116 = self._extract_value_string(config.get("csv_compression"), "")
compression = _t2116
_t2117 = self._extract_value_int64(config.get("csv_partition_size_mb"), 0)
partition_size_mb = _t2117
Expand Down
Binary file modified tests/bin/cdc.bin
View file
Open in desktop
Binary file not shown.
Binary file modified tests/bin/csv.bin
View file
Open in desktop
Binary file not shown.
Binary file modified tests/bin/csv_export_v2.bin
View file
Open in desktop
Binary file not shown.
Binary file modified tests/bin/csv_storage_integration.bin
View file
Open in desktop
Binary file not shown.
Binary file modified tests/bin/snapshot.bin
View file
Open in desktop
Binary file not shown.
Binary file modified tests/bin/unicode.bin
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion tests/pretty/cdc.lqp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
(csv_locator (paths "s3://bucket/cdc/batch_001.csv"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand Down
8 changes: 4 additions & 4 deletions tests/pretty/csv.lqp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
(csv_locator (paths "s3://bucket/data/file1.csv" "s3://bucket/data/file2.csv"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand Down Expand Up @@ -44,7 +44,7 @@
(csv_locator (inline_data "user_id,name,score\n1,Alice,95.5\n2,Bob,87.3"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -61,7 +61,7 @@
(csv_locator (paths "/local/path/data.csv"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter "\t"
:csv_encoding "utf-8"
Expand All @@ -77,7 +77,7 @@
(csv_locator (paths "data/infer.csv"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand Down
22 changes: 11 additions & 11 deletions tests/pretty/csv_export_v2.lqp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
(table_def :users)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -85,7 +85,7 @@
(table_def :users)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter "|"
:csv_encoding "utf-8"
Expand Down Expand Up @@ -114,7 +114,7 @@
(table_def :products)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -128,7 +128,7 @@
(table_def :events)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -142,7 +142,7 @@
(table_def :users)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter "\t"
:csv_encoding "utf-8"
Expand All @@ -156,7 +156,7 @@
(table_def :simple)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -170,7 +170,7 @@
(table_def :names)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -188,7 +188,7 @@
(column "active" :col_active))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -202,7 +202,7 @@
(gnf_columns (column "user_id" :col_id) (column "user_name" :col_name))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -216,7 +216,7 @@
(gnf_columns (column "id" :col_id) (column "score" :col_score))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -230,7 +230,7 @@
(gnf_columns (column "score" :col_score))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand Down
6 changes: 3 additions & 3 deletions tests/pretty/csv_storage_integration.lqp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
(csv_locator (paths "s3://private-bucket/data.csv"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -24,7 +24,7 @@
(csv_locator (paths "https://account.blob.core.windows.net/container/data.csv"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter "|"
:csv_encoding "utf-8"
Expand All @@ -50,7 +50,7 @@
(table_def :exported)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand Down
2 changes: 1 addition & 1 deletion tests/pretty/snapshot.lqp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"id,big_signed,big_unsigned\n1,170141183460469231731687303715884105727,340282366920938463463374607431768211455\n2,-170141183460469231731687303715884105728,0\n3,0,1"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand Down
2 changes: 1 addition & 1 deletion tests/pretty/unicode.lqp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"id,name,city,greeting\n1,François,Paris,Bonjour\n2,田中,東京,こんにちは\n3,Müller,München,Grüß Gott\n4,Иван,Москва,Привет"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand Down
2 changes: 1 addition & 1 deletion tests/pretty_debug/cdc.lqp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
(csv_locator (paths "s3://bucket/cdc/batch_001.csv"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand Down
8 changes: 4 additions & 4 deletions tests/pretty_debug/csv.lqp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
(csv_locator (paths "s3://bucket/data/file1.csv" "s3://bucket/data/file2.csv"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand Down Expand Up @@ -44,7 +44,7 @@
(csv_locator (inline_data "user_id,name,score\n1,Alice,95.5\n2,Bob,87.3"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -61,7 +61,7 @@
(csv_locator (paths "/local/path/data.csv"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter "\t"
:csv_encoding "utf-8"
Expand All @@ -77,7 +77,7 @@
(csv_locator (paths "data/infer.csv"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand Down
22 changes: 11 additions & 11 deletions tests/pretty_debug/csv_export_v2.lqp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
(table_def 0xfcec892cae7f6ee39b75f34e659d672c)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -85,7 +85,7 @@
(table_def 0xfcec892cae7f6ee39b75f34e659d672c)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter "|"
:csv_encoding "utf-8"
Expand Down Expand Up @@ -114,7 +114,7 @@
(table_def 0xe6d1c919204e329c580fbc9429ab4f9)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -128,7 +128,7 @@
(table_def 0x2d787823b6f9a0f453e42824c5a4d4b6)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -142,7 +142,7 @@
(table_def 0xfcec892cae7f6ee39b75f34e659d672c)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter "\t"
:csv_encoding "utf-8"
Expand All @@ -156,7 +156,7 @@
(table_def 0x7057b7a1c77d1fe321a1afcff041d4e1)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -170,7 +170,7 @@
(table_def 0x8556eb0fb49a215ae5eb1b970cad0315)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -188,7 +188,7 @@
(column "active" 0xa97bc5091457148653c6a521ac05bfc1))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -204,7 +204,7 @@
(column "user_name" 0xb87a660519d4c6d737802ad8ccc0cbbb))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -220,7 +220,7 @@
(column "score" 0x1cc0df3ea1ebf5a81b22377b3d414fad))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -234,7 +234,7 @@
(gnf_columns (column "score" 0x1cc0df3ea1ebf5a81b22377b3d414fad))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand Down
6 changes: 3 additions & 3 deletions tests/pretty_debug/csv_storage_integration.lqp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
(csv_locator (paths "s3://private-bucket/data.csv"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand All @@ -26,7 +26,7 @@
(csv_locator (paths "https://account.blob.core.windows.net/container/data.csv"))
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter "|"
:csv_encoding "utf-8"
Expand Down Expand Up @@ -54,7 +54,7 @@
(table_def 0xe239456d024bc2c38b99cd9d5fabadab)
(csv_config
{
:csv_compression "auto"
:csv_compression ""
:csv_decimal_separator "."
:csv_delimiter ","
:csv_encoding "utf-8"
Expand Down
Loading
Loading