Skip to content

Restore AllocOptPass in the -O1 scalar optimizer pipeline #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rbvermaa wants to merge 1 commit into
base: v1.12.6+RAI
Choose a base branch
from
Open

Restore AllocOptPass in the -O1 scalar optimizer pipeline #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/pipeline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,19 @@ static void buildScalarOptimizerPipeline(FunctionPassManager &FPM, PassBuilder *
FPM.addPass(IRCEPass());
FPM.addPass(InstCombinePass());
FPM.addPass(JumpThreadingPass());
} else if (O.getSpeedupLevel() >= 1) {
// RAI: backport of the -O1 branch added upstream by JuliaLang/julia#52850,
// which was carried to release-1.10 (#57731) and release-1.11 (#57732) but
// never to release-1.12. Without AllocOptPass here, a non-escaping Ref that
// is only used via pointer_from_objref is heap-allocated at -O1, while it is
// elided on 1.10/1.11 and at -O2+ on every version. Our test suite runs at
// -O1 and asserts such code is allocation-free.
JULIA_PASS(FPM.addPass(AllocOptPass()));
FPM.addPass(SROAPass(SROAOptions::ModifyCFG));
FPM.addPass(MemCpyOptPass());
FPM.addPass(SCCPPass());
FPM.addPass(InstCombinePass());
FPM.addPass(ADCEPass());
}
if (O.getSpeedupLevel() >= 3) {
FPM.addPass(GVNPass());
Expand Down
Loading