fix(workflow): use $sourceDescriptions for workflow references#2867
fix(workflow): use $sourceDescriptions for workflow references#2867harshit078 wants to merge 10 commits into
Conversation
🦋 Changeset detectedLatest commit: d692b6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @DmitryAnansky , Can you review the PR and check it ? Thanks ! |
Performance Benchmark (Lower is Faster)
|
| if (workflow) { | ||
| return workflow; | ||
| } | ||
| } |
There was a problem hiding this comment.
Probably we need to handle case with
if (isLegacyForm) {
return undefined;
}
|
Could you please update existing tests to use correct and not legacy format? |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 658bf13. Configure here.

What/Why/How?
$sourceDescriptions.<name>.<workflowId>.$sourceDescriptions.<name>.workflows.<workflowId>form is still maintained.Reference
#2826
Testing
Screenshots (optional)
Check yourself
Security
Note
Low Risk
Localized change to context path parsing with backward compatibility and broad test updates; no auth or data-layer impact.
Overview
Adds Arazzo-compliant external workflow references as
$sourceDescriptions.<name>.<workflowId>(without a.workflows.segment) inget-value-from-contextresolution, so Respect can resolve referenced workflows the way the spec describes.The older
$sourceDescriptions.<name>.workflows.<workflowId>syntax still works. For the spec form, if the third segment is not a matchingworkflowId, resolution falls back to a property on the source description (e.g.$sourceDescriptions.test.url).Tests and flow-runner examples were updated to the spec form, with explicit coverage for legacy paths and spec fallbacks.
Reviewed by Cursor Bugbot for commit d692b6c. Bugbot is set up for automated code reviews on this repo. Configure here.