Draft
Conversation
🦋 Changeset detectedLatest commit: 81fe95d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2f635d9 to
60ef033
Compare
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Contributor
|
Contributor
Author
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ecbaf4e. Configure here.
Contributor
|
📦 A new experimental 🧪 version v0.0.0-snapshot.1777378978 of Redocly CLI has been published for testing. Install with NPM: npm install @redocly/cli@0.0.0-snapshot.1777378978
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1777378978
# or
npm install @redocly/respect-core@0.0.0-snapshot.1777378978 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What/Why/How?
Fixed bundling for $ref siblings so sibling properties are resolved reliably, including nested external refs and non-Schema sibling contexts.
Important
Bundling now resolves all sibling properties next to
$ref, regardless of whether the node is interpreted as a Reference Object or a Schema Object.This is important because OpenAPI 3.1 distinguishes these cases in the spec:
Reference
OpenAPI 3.1 — Reference Object
bundle#1329Testing
Screenshots (optional)
Check yourself
Security
Note
Medium Risk
Touches core AST traversal in
walk.ts, which can subtly affect how refs and scalar fields are processed across bundling/dereferencing. Added unit and e2e fixtures reduce regression risk but behavior may change for edge-case specs relying on previous resolution order.Overview
Bundling now resolves sibling fields next to
$refmore reliably, including cases where sibling content contains nested external$refs and where$refis used as a schema wrapper with additional keywords.The traversal in
walk.tswas adjusted to ensure sibling properties on the original node are walked appropriately rather than being skipped/treated as scalars, and new unit + e2e tests/fixtures were added to lock in the expected bundled and--dereferencedoutputs. A changeset bumps@redocly/openapi-coreand@redocly/cliwith a patch fix note.Reviewed by Cursor Bugbot for commit ecbaf4e. Bugbot is set up for automated code reviews on this repo. Configure here.