Skip to content

[SVS] Add SVS Index TopK benchmark#991

Open
rfsaliev wants to merge 2 commits into
mainfrom
rfsaliev/svs-bm-topk
Open

[SVS] Add SVS Index TopK benchmark#991
rfsaliev wants to merge 2 commits into
mainfrom
rfsaliev/svs-bm-topk

Conversation

@rfsaliev

@rfsaliev rfsaliev commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Add TopK search benchmark for SVS Vamana index

Which issues this PR fixes

  1. #...
  2. MOD...

Main objects this PR modified

  1. ...
  2. ...

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Note

Low Risk
Benchmark-only changes with no production or API impact.

Overview
Adds TopK search coverage for the SVS Vamana index in the benchmark suite, parallel to existing HNSW/flat TopK tests.

TopK_SVS loads a prebuilt SVS index via CreateSVSIndexFromFile, runs VecSimIndex_TopKQuery with SVSRuntimeParams.windowSize (search window) and k from benchmark args, rotates through loaded query vectors, and frees the index after the run.

BM_TopK is registered for fp32 SVS with millisecond timing, 10 iterations, and five {window_size, k} pairs (e.g. 10/10 through 500/500) to sweep accuracy/latency tradeoffs.

Reviewed by Cursor Bugbot for commit 225902c. Bugbot is set up for automated code reviews on this repo. Configure here.

alonre24
alonre24 previously approved these changes Jul 9, 2026
@rfsaliev rfsaliev added this pull request to the merge queue Jul 9, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 9, 2026
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.10%. Comparing base (6ca08ae) to head (225902c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #991   +/-   ##
=======================================
  Coverage   97.10%   97.10%           
=======================================
  Files         141      141           
  Lines        8179     8179           
=======================================
  Hits         7942     7942           
  Misses        237      237           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rfsaliev rfsaliev enabled auto-merge July 9, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants