Skip to content

Bump GitHub Actions to Node 24 compatible versions [MOD-15112] #947

Merged
dor-forer merged 1 commit intomainfrom
dorer-mod-15112-node20-deprecation
May 4, 2026
Merged

Bump GitHub Actions to Node 24 compatible versions [MOD-15112] #947
dor-forer merged 1 commit intomainfrom
dorer-mod-15112-node20-deprecation

Conversation

@dor-forer
Copy link
Copy Markdown
Collaborator

@dor-forer dor-forer commented May 4, 2026

Describe the changes in the pull request

Migrate all JavaScript-based GitHub Actions in .github/workflows/ to versions running on the Node 24 runtime, ahead of the June 2, 2026 Node 20 deprecation.

Version bumps:

Action Old New
actions/checkout v4 v6
actions/setup-python v5 v6
actions/upload-artifact v4 v7
aws-actions/configure-aws-credentials v4 v6
machulav/ec2-github-runner v2.4.2 v2.6.1
codecov/codecov-action v4 v6
github/codeql-action/* v3 v4
korthout/backport-action v3 v4
release-drafter/release-drafter v6 v7
slackapi/slack-github-action v1 v3

slackapi/slack-github-action v1 → v3 in event-nightly.yml requires an API change: the SLACK_WEBHOOK_URL env var is replaced by explicit webhook and webhook-type: incoming-webhook action inputs.

rojopolis/spellcheck-github-actions@v0 is left as-is (Docker-based action, not Node-based).

Which issues this PR fixes

  1. MOD-15112

Main objects this PR modified

  1. .github/workflows/arm.yml
  2. .github/workflows/benchmark-runner.yml
  3. .github/workflows/codeql-analysis.yml
  4. .github/workflows/coverage.yml
  5. .github/workflows/event-nightly.yml
  6. .github/workflows/event-pull_request.yml
  7. .github/workflows/release-drafter.yml
  8. .github/workflows/task-backport_pr.yml
  9. .github/workflows/task-unit-test.yml

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Note

Medium Risk
Moderate risk because it upgrades multiple third-party GitHub Actions across CI, including AWS runner lifecycle, CodeQL, and Codecov steps; failures would block builds or leak incomplete artifacts rather than change product behavior.

Overview
Updates CI workflows to use newer, Node 24-compatible versions of key GitHub Actions (e.g., actions/checkout, setup-python, upload-artifact, AWS credentials, EC2 runner management, CodeQL, Codecov, Release Drafter, and backport automation).

Adjusts the nightly Slack notification step to the slackapi/slack-github-action@v3 input format by passing the webhook via with.webhook/webhook-type instead of the deprecated SLACK_WEBHOOK_URL env var.

Reviewed by Cursor Bugbot for commit 24736b4. Bugbot is set up for automated code reviews on this repo. Configure here.

Migrate all JavaScript-based GitHub Actions to versions running on the
Node 24 runtime ahead of the June 2, 2026 Node 20 deprecation.

- actions/checkout v4 -> v6
- actions/setup-python v5 -> v6
- actions/upload-artifact v4 -> v7
- aws-actions/configure-aws-credentials v4 -> v6
- machulav/ec2-github-runner v2.4.2 -> v2.6.1
- codecov/codecov-action v4 -> v6
- github/codeql-action/* v3 -> v4
- korthout/backport-action v3 -> v4
- release-drafter/release-drafter v6 -> v7
- slackapi/slack-github-action v1 -> v3 (input-based webhook config)
@jit-ci
Copy link
Copy Markdown

jit-ci Bot commented May 4, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@dor-forer dor-forer changed the title [MOD-15112] Bump GitHub Actions to Node 24 compatible versions Bump GitHub Actions to Node 24 compatible versions [MOD-15112] May 4, 2026
@dor-forer dor-forer requested a review from GuyAv46 May 4, 2026 12:49
@dor-forer dor-forer marked this pull request as ready for review May 4, 2026 12:49
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 24736b4. Configure here.

run: make coverage
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v6 # NOSONAR
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated file input not migrated to files

Medium Severity

The codecov/codecov-action was bumped from v4 to v6, but the file input on this line was not updated to files. The file input was deprecated in v5 in favor of files. Combined with disable_search: true (which prevents automatic coverage file discovery), if the deprecated file alias stops being recognized in a future v6 patch, no coverage file will be specified or discovered, causing the upload step to silently produce no results.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 24736b4. Configure here.

@dor-forer dor-forer enabled auto-merge May 4, 2026 12:55
@dor-forer dor-forer added this pull request to the merge queue May 4, 2026
Merged via the queue into main with commit 369f14f May 4, 2026
31 checks passed
@dor-forer dor-forer deleted the dorer-mod-15112-node20-deprecation branch May 4, 2026 14:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Backport failed for 0.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 0.6
git worktree add -d .worktree/backport-947-to-0.6 origin/0.6
cd .worktree/backport-947-to-0.6
git switch --create backport-947-to-0.6
git cherry-pick -x 369f14fb01ef7b827e4242f543460a15750d82ca

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Backport failed for 0.7, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 0.7
git worktree add -d .worktree/backport-947-to-0.7 origin/0.7
cd .worktree/backport-947-to-0.7
git switch --create backport-947-to-0.7
git cherry-pick -x 369f14fb01ef7b827e4242f543460a15750d82ca

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Backport failed for 0.8, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 0.8
git worktree add -d .worktree/backport-947-to-0.8 origin/0.8
cd .worktree/backport-947-to-0.8
git switch --create backport-947-to-0.8
git cherry-pick -x 369f14fb01ef7b827e4242f543460a15750d82ca

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Backport failed for 8.2, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 8.2
git worktree add -d .worktree/backport-947-to-8.2 origin/8.2
cd .worktree/backport-947-to-8.2
git switch --create backport-947-to-8.2
git cherry-pick -x 369f14fb01ef7b827e4242f543460a15750d82ca

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Successfully created backport PR for 8.4:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants