Fix -Wmaybe-uninitialized with GCC 16 in CHOOSE_IMPLEMENTATION macros#945
Open
daxhuiberts wants to merge 1 commit intoRedisAI:mainfrom
Open
Fix -Wmaybe-uninitialized with GCC 16 in CHOOSE_IMPLEMENTATION macros#945daxhuiberts wants to merge 1 commit intoRedisAI:mainfrom
daxhuiberts wants to merge 1 commit intoRedisAI:mainfrom
Conversation
GCC 16 improved its uninitialized variable analysis and now warns that `__ret_dist_func` may be used uninitialized: the switch is exhaustive (e.g. `CASES16` covers exactly 0-15 and `dim % 16` can only produce 0-15), but GCC cannot prove this from the recursive macro expansion. Add `default: __builtin_unreachable()` to both `CHOOSE_IMPLEMENTATION` and `CHOOSE_SVE_IMPLEMENTATION` to explicitly signal to the compiler that no other case is reachable, allowing it to conclude the variable is always initialized before use.
|
= seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 16 improved its uninitialized variable analysis and now warns that
__ret_dist_funcmay be used uninitialized: the switch is exhaustive (e.g.CASES16covers exactly 0-15 anddim % 16can only produce 0-15), but GCC cannot prove this from the recursive macro expansion.Add
default: __builtin_unreachable()to bothCHOOSE_IMPLEMENTATIONandCHOOSE_SVE_IMPLEMENTATIONto explicitly signal to the compiler that no other case is reachable, allowing it to conclude the variable is always initialized before use.Note
Low Risk
Low risk, compile-time-only change adding
default: __builtin_unreachable()to exhaustive switch macros to satisfy newer GCC uninitialized-variable analysis. Runtime behavior should be unchanged unless invariants are violated, in which case it becomes UB as intended.Overview
Fixes GCC 16
-Wmaybe-uninitializedwarnings in the SIMD implementation selection macros by making theswitchstatements explicitly exhaustive.Adds
default: __builtin_unreachable()to bothCHOOSE_IMPLEMENTATIONandCHOOSE_SVE_IMPLEMENTATION, ensuring__ret_dist_funcis always considered initialized when the remainder/step calculations are within expected ranges.Reviewed by Cursor Bugbot for commit 2a25d9c. Bugbot is set up for automated code reviews on this repo. Configure here.