Skip to content

Fix -Wmaybe-uninitialized with GCC 16 in CHOOSE_IMPLEMENTATION macros#945

Open
daxhuiberts wants to merge 1 commit intoRedisAI:mainfrom
daxhuiberts:dax-fix-gcc16
Open

Fix -Wmaybe-uninitialized with GCC 16 in CHOOSE_IMPLEMENTATION macros#945
daxhuiberts wants to merge 1 commit intoRedisAI:mainfrom
daxhuiberts:dax-fix-gcc16

Conversation

@daxhuiberts
Copy link
Copy Markdown

@daxhuiberts daxhuiberts commented May 1, 2026

GCC 16 improved its uninitialized variable analysis and now warns that __ret_dist_func may be used uninitialized: the switch is exhaustive (e.g. CASES16 covers exactly 0-15 and dim % 16 can only produce 0-15), but GCC cannot prove this from the recursive macro expansion.

Add default: __builtin_unreachable() to both CHOOSE_IMPLEMENTATION and CHOOSE_SVE_IMPLEMENTATION to explicitly signal to the compiler that no other case is reachable, allowing it to conclude the variable is always initialized before use.


Note

Low Risk
Low risk, compile-time-only change adding default: __builtin_unreachable() to exhaustive switch macros to satisfy newer GCC uninitialized-variable analysis. Runtime behavior should be unchanged unless invariants are violated, in which case it becomes UB as intended.

Overview
Fixes GCC 16 -Wmaybe-uninitialized warnings in the SIMD implementation selection macros by making the switch statements explicitly exhaustive.

Adds default: __builtin_unreachable() to both CHOOSE_IMPLEMENTATION and CHOOSE_SVE_IMPLEMENTATION, ensuring __ret_dist_func is always considered initialized when the remainder/step calculations are within expected ranges.

Reviewed by Cursor Bugbot for commit 2a25d9c. Bugbot is set up for automated code reviews on this repo. Configure here.

GCC 16 improved its uninitialized variable analysis and now warns that
`__ret_dist_func` may be used uninitialized: the switch is exhaustive
(e.g. `CASES16` covers exactly 0-15 and `dim % 16` can only produce
0-15), but GCC cannot prove this from the recursive macro expansion.

Add `default: __builtin_unreachable()` to both `CHOOSE_IMPLEMENTATION`
and `CHOOSE_SVE_IMPLEMENTATION` to explicitly signal to the compiler
that no other case is reachable, allowing it to conclude the variable
is always initialized before use.
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


= seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jit-ci
Copy link
Copy Markdown

jit-ci Bot commented May 1, 2026

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants