Skip to content

taxonomy: add GitLab CI slug - #79

Merged
jpbelmo merged 2 commits into
Redential:mainfrom
SulimanAbdulrazzaq:agent/add-gitlab-ci-taxonomy
Aug 10, 2026
Merged

taxonomy: add GitLab CI slug#79
jpbelmo merged 2 commits into
Redential:mainfrom
SulimanAbdulrazzaq:agent/add-gitlab-ci-taxonomy

Conversation

@SulimanAbdulrazzaq

@SulimanAbdulrazzaq SulimanAbdulrazzaq commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

What does this PR do, and why does it fit the north star?

Adds infra/gitlab-ci to the closed skill taxonomy and advances its version from 1.14.0 to 1.15.0.

GitLab CI is a distinct, widely used CI platform whose .gitlab-ci.yml and .gitlab/ci/*.yml paths can provide deterministic local evidence. Adding the slug first keeps vocabulary review separate from the dependent signature work required by #24.

Checklist

  • Tests pass locally (npm test) — the default 5-second Windows fixture timeout is reproducibly too short on this machine; the exact failed test passes with a 30-second timeout
  • npm run typecheck passes

If this adds or changes a detection signature

  • Includes positive and negative fixtures — not applicable to this taxonomy-only prerequisite
  • The slug already exists — not applicable; this PR adds the prerequisite vocabulary entry

If this touches WHAT data leaves the machine, or WHERE it's sent

If this adds a new runtime dependency

  • Written justification included — not applicable; no dependency changes

Docs and changelog

  • CHANGELOG.md entry added under [Unreleased]
  • Relevant doc updated — not applicable to the vocabulary-only prerequisite

Additional context

The branch is updated with current upstream main, including the Razorpay and Okta taxonomy entries at version 1.14.0.

Validation:

  • npm run typecheck: passed
  • npm run build: passed
  • package-map, skill-detect, and taxonomy contract tests: 133 passed
  • test/privacy/submit-guardrail.test.ts --testTimeout=30000 --hookTimeout=30000: 4 passed
  • git diff --check: passed

The Windows Node 20 CI failure is a single 5-second timeout in submit-guardrail.test.ts; 862/863 tests passed. The same upstream SHA passes Windows Node 20, all other matrix jobs pass, and the taxonomy-only diff does not touch that test or runtime path.

This PR intentionally references rather than closes #24. The GitLab CI signature, positive and near-miss fixtures, and changelog entry remain a separate follow-up after this slug is merged.

@SulimanAbdulrazzaq
SulimanAbdulrazzaq force-pushed the agent/add-gitlab-ci-taxonomy branch from 3551506 to 5c66c1e Compare August 9, 2026 06:30
@SulimanAbdulrazzaq

Copy link
Copy Markdown
Contributor Author

The Windows Node 20 failure appears timing-related rather than caused by this taxonomy-only diff: CI passed 862/863 tests and timed out only in submit-guardrail at the 5-second limit, while the same current upstream SHA passes that job. Locally, the exact test passes 4/4 with a 30-second timeout; typecheck, build, and the 133 taxonomy-related tests also pass. I cannot rerun repository Actions from the fork, so a maintainer rerun of the failed job would be appreciated.

@jpbelmo

jpbelmo commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Your diagnosis is exactly right, and it's our flake, not your diff: third file with the same Windows 5s-timeout pattern this week. Rerun was already launched when your comment landed; it's running now. A repo-side fix raising those fixture-test timeouts is queued. Thanks for the textbook triage, local repro included.

@jpbelmo
jpbelmo merged commit da69082 into Redential:main Aug 10, 2026
13 of 14 checks passed
jpbelmo added a commit that referenced this pull request Aug 10, 2026
Windows CI runners intermittently exceed vitest's 5s default in tests
that build real git fixtures and drive the submit flow against a mock
server (observed on the PR #70 and #79 matrices). Same fix
test/submit.test.ts received on 2026-08-05; no assertion changes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015cG33p5HAAqi81QNiSo4Yx
@SulimanAbdulrazzaq

Copy link
Copy Markdown
Contributor Author

Thanks for confirming the diagnosis and rerunning the job. I’ll keep the GitLab CI detection work as the separate follow-up required by #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI-platform signatures: GitLab CI, CircleCI, Jenkins (pick one)

2 participants