fix: remove dead variableref_checked_collection_typeof (unbound ref) - #315
Open
docxology wants to merge 1 commit into
Open
fix: remove dead variableref_checked_collection_typeof (unbound ref)#315docxology wants to merge 1 commit into
variableref_checked_collection_typeof (unbound ref)#315docxology wants to merge 1 commit into
Conversation
Unused function referenced an unbound local 'ref' (latent UndefVarError).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3.
src/graph_engine.jl:1062-1064definesvariableref_checked_collection_typeof(::VariableRef)which references a never-bound
ref(wouldUndefVarErroron any call). The function has nocallers anywhere in the repo, so it is removed.
Change
Delete the function (and no other code references it, per
grep).Verification
src/graph_engine.jlcompiles;grepforvariableref_checked_collection_typeofnow returnsno definitions.