PR draft — Validate captured value in ClosedForm closure extraction (fixes issue-06) - #109
Open
docxology wants to merge 1 commit into
Open
PR draft — Validate captured value in ClosedForm closure extraction (fixes issue-06)#109docxology wants to merge 1 commit into
docxology wants to merge 1 commit into
Conversation
…d silent wrong target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
exmplatepreprocess_strategy_argument(::ClosedFormStrategy, argument::F)takesgetfield(argument, first(fieldnames(F)))with no type check; multi-variable closures silently retrieve the wrong (first) captured value.Change
ext/ClosedFormExpectationsExt/ClosedFormExpectationsExt.jl:Optionally, when more than one field is captured, prefer the field whose value is a
Distribution/ProductOfand error only if none is found.Verification
let a = 5, d = Normal(0,1); fn=(x)->logpdf(d,x)+a; preprocess_strategy_argument(...)now errors with a clear message instead of silently projecting the scalar5.