replace old attributes name for rdevel windows#7813
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7813 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 88 88
Lines 17228 17228
=======================================
Hits 17059 17059
Misses 169 169 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
I'm merging this without review since it is mostly CI |
Member
Author
|
Since this also errors on the CRAN checks, I guess we can expect a deadline email soonish |
Member
|
Thanks for the fix! Please monitor ancient pipeline to ensure this also WAI in very old R. For reference, this is r90216. Also, FWIW, I try to avoid using |
Member
|
Backported this fix just in case on the patch-1.18.6 branch (and also a
few other bug fixes). We could also press on and release 1.19, I should
have more time for this in the coming weeks.
The ancient pipeline currently fails during test 2367.1 for unrelated
reasons (file contents not valid in locale encoding, and char.trunc()
needs nchar() to work).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of rdvel warns when legacy attribute aliases are assigned