Skip to content

replace old attributes name for rdevel windows#7813

Merged
ben-schwen merged 2 commits into
masterfrom
rdevel_windows_old_attribute_names
Jul 12, 2026
Merged

replace old attributes name for rdevel windows#7813
ben-schwen merged 2 commits into
masterfrom
rdevel_windows_old_attribute_names

Conversation

@ben-schwen

Copy link
Copy Markdown
Member

New version of rdvel warns when legacy attribute aliases are assigned

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (81876f7) to head (fcc9f7d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7813   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          88       88           
  Lines       17228    17228           
=======================================
  Hits        17059    17059           
  Misses        169      169           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-schwen

Copy link
Copy Markdown
Member Author

I'm merging this without review since it is mostly CI

@ben-schwen ben-schwen merged commit f55ed35 into master Jul 12, 2026
13 checks passed
@ben-schwen

Copy link
Copy Markdown
Member Author

Since this also errors on the CRAN checks, I guess we can expect a deadline email soonish

@MichaelChirico MichaelChirico deleted the rdevel_windows_old_attribute_names branch July 13, 2026 18:20
@MichaelChirico

Copy link
Copy Markdown
Member

Thanks for the fix! Please monitor ancient pipeline to ensure this also WAI in very old R.

For reference, this is r90216. Also, FWIW, I try to avoid using structure() as it's slower and a bit ugly -- it's one of the lintr::default_undesirable_functions, but we have {lintr} disabled on Rraw for now: #6266

@aitap

aitap commented Jul 13, 2026 via email

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants