Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7807 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 88 88
Lines 17219 17234 +15
=======================================
+ Hits 17050 17065 +15
Misses 169 169 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Generated via commit 52d0929 Download link for the artifact containing the test results: ↓ atime-results.zip
|
| ansvals = chmatch(ansvars, names_x) | ||
| } | ||
| # if (!length(ansvars)) Leave ansvars empty. Important for test 607. | ||
| if (".SD" %chin% av && any(all.names(jsub) %chin% c("<-", "="))) { |
There was a problem hiding this comment.
curious: will we ever have a situation where we could have a DT nested within the expression? would the top level DT warn or the nested?
There was a problem hiding this comment.
i have verified with nested scenarios. since the check runs per [.data.table call, warnings are correctly scope sensitive. only the DT whose columns are locally shadowed will warn. If both share a column name being assigned, both will correctly warn.
| test(2377.91, truelength(dt$a), 0L) | ||
| test(2377.92, {setallocrow(dt); truelength(dt$a)}, 3L) | ||
|
|
||
| # 7431 warn when .SD is returned after local assignment to .SD columns |
There was a problem hiding this comment.
I would keep # and issue number together, as this is how we always search for comments related to an issue
3 participants
closes #7431
this pr updates :