feat: truncate long text in menu items#9946
Open
LappiLappland wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9930
Proposed Changes
In MenuItem truncate text if it is longer than
maxDisplayLength. Bind tooltip to element if text got truncatedBehaviour is similar to existing code in
Field-> defining max length and manually truncating textDoes not truncate text if HTML element was passed. The default value of
50is consistent with existing limits used elsewhere (Tooltip limit, Field limit)Existing tooltips API is used to display tooltip text
Reason for Changes
Options' text in some menus (context menus, variable menu) is determined by user input. Dynamic options for variable/procedure names can span beyond screen
Test Coverage
Added 2 tests to
menu_item_test.jsDocumentation
Additional Information