Cross origin copy - #2761
Open
TannerGabriel wants to merge 1 commit into
Open
Conversation
Contributor
|
Hey, thanks for the PR! I think there's a couple problems with this that would prevent us from accepting as is, but before I do a detailed review I want to check with @gonfunko because he's looked at this lately and may have some work in progress, other review thoughts, or we might think this isn't worth putting in the plugin if it's going to move into core. Blocking issues with this approach:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2496
Proposed Changes
I personally use the system clipboard for copying between different origins and thought I would share the implementation. Let me know if this is what you had in mind.