Conversation
gonfunko
approved these changes
Jul 27, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2678
Proposed Changes
field-grid-dropdown:Ensure aria role and field type name are accurate, including when expanding/collapsing. Use an existing translation for the type name.
Change type of
FieldGridDropdown.gridtoGrid | nullto better align toFieldDropdown.menu.Rework
Grid.moveFocus()to support vertical wrapping:movementIndexof 1/-1 (previously it was a number with a larger absolute value based on the number of columns) andhorizontal = false.getVerticalTargetIndexwhich handles the actual wrapping logic.targetItemcan be found.In the screenshot above, up/down can now be used to navigate between M/B and K/C, but not L/A.
Reason for Changes
Grids have been somewhat tricky for keyboard/screenreader navigation. If they are announced as a list, users tend to only go down the first column and not ever discover there are more columns.