Skip to content

fix: Minimap variable renaming #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maribethb merged 1 commit into from
Jul 27, 2026
+43 −0
Merged

fix: Minimap variable renaming #2756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plugins/workspace-minimap/src/focus_region.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ const blockEvents = new Set<string>([
Blockly.Events.BLOCK_DELETE,
Blockly.Events.BLOCK_DRAG,
Blockly.Events.BLOCK_MOVE,
Blockly.Events.VAR_RENAME,
]);

const borderRadius = 6;
Expand Down
3 changes: 3 additions & 0 deletions plugins/workspace-minimap/src/minimap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ const blockEvents = new Set<string>([
Blockly.Events.BLOCK_DELETE,
Blockly.Events.BLOCK_DRAG,
Blockly.Events.BLOCK_MOVE,
Blockly.Events.VAR_CREATE,
Blockly.Events.VAR_DELETE,
Blockly.Events.VAR_RENAME,
]);

/** Default primary-workspace pixels to pan per arrow keypress. */
Expand Down
39 changes: 39 additions & 0 deletions plugins/workspace-minimap/test/minimap_tests.mocha.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,45 @@ suite('Positioning the minimap in the primary workspace', function () {
});
});

suite('Mirroring events', function () {
setup(function () {
this.jsdomCleanup = require('jsdom-global')(
'<!DOCTYPE html><div id="blocklyDiv"></div>',
);
global.SVGElement = window.SVGElement;
window.requestAnimationFrame = (callback) => setTimeout(callback, 0);
window.cancelAnimationFrame = (id) => clearTimeout(id);
this.workspace = Blockly.inject('blocklyDiv', {
move: {scrollbars: true},
});
this.minimap = new Minimap(this.workspace);
this.minimap.init();
});

teardown(function () {
this.minimap.dispose();
this.workspace.dispose();
this.jsdomCleanup();
});

test('Renaming a variable updates the minimap', async function () {
const variable = this.workspace.getVariableMap().createVariable('a');
const block = this.workspace.newBlock('variables_set');
block.getField('VAR').setValue(variable.getId());
await new Promise((resolve) => setTimeout(resolve, 0));

this.workspace.getVariableMap().renameVariable(variable, 'b');
await new Promise((resolve) => setTimeout(resolve, 0));

const minimapBlock = this.minimap.minimapWorkspace.getBlockById(block.id);
assert.equal(
minimapBlock.getField('VAR').getText(),
'b',
'Minimap block should show the renamed variable',
);
});
});

suite('Keyboard navigation', function () {
setup(function () {
this.jsdomCleanup = require('jsdom-global')(
Expand Down
Loading