Add a python equivalent to MATLABs smoothdata and use in Bayes plots#208
Open
MikeSullivan7 wants to merge 1 commit into
Open
Add a python equivalent to MATLABs smoothdata and use in Bayes plots#208MikeSullivan7 wants to merge 1 commit into
MikeSullivan7 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with the Bayes plots smoothing not functioning correctly for background parameters. The issue comes from the use of
scipy.ndimage.gaussian_filter1dinstead of a moving average smoothing as is used in MATLAB:smoothdata(N, 'movmean').This PR fixes the issue by implimenting a python version of
smoothdataand the function has been benchmarked against results from MATLAB.smoothdataautomatically calculates the averaging window to use but there is no real explanation on how this is calculated. This has been set to 8 as default as this is the value used by MATLAB for RAT data most commonly.Benchmark for noisy data:
Example of new smoothing for Substrate Roughness example:
Old smoothing:
New smoothing:
