New resolution function - #447
Merged
StephenNneji merged 5 commits intoAug 24, 2026
Merged
Conversation
StephenNneji
force-pushed
the
newResolutionFunc
branch
from
August 21, 2026 08:55
590b5cd to
d3838db
Compare
DrPaulSharp
approved these changes
Aug 24, 2026
DrPaulSharp
left a comment
DrPaulSharp
left a comment
Collaborator
There was a problem hiding this comment.
This all looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the old sliding Gaussian resolution function ('resolutionPolly') with a more robust implementation. This now passes the remaining ORSO tests, although these have not yet been included in the testing suite.
The remaining tests have been modified (inputs and outputs) to account for the slightly different Simulation values which arise from the modified resolution.
All the examples run satisfactory, and there is no apparent penalty for speed.