Numba-enhanced Data Averaging (and more!) - #1694
Open
kartographer wants to merge 7 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1694 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 67 69 +2
Lines 22982 23038 +56
=======================================
+ Hits 22968 23024 +56
Misses 14 14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A new numba kernel for averaging data (with arbitrary grouping along one axis) has been added and integrated into
UVData.frequency_averageandUVData.downsample_in_time, which should substantially increase its speed (via multithreaded processing) and significantly reduce the memory footprint of the averaging step.Motivation and Context
The primary motivation for this was addressing the speed and memory issue with frequency averaging, given the prior report about MWA data suffering a ~6x increase in memory footprint, although because the new kernel is somewhat flexibly designed to handle irregularly grouped arrays, I took the opportunity to add a few additional features to
frequency_average(including an option to sum acrossnsample_array, which is appropriate for when it's being used to carry weights, as is the case in a few different filetypes).Closes #730
Closes #1311
Closes #1624
Types of changes
Checklist:
New feature checklist: