Time-based interpolation of UVCal calibration tables - #1691
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1691 +/- ##
========================================
Coverage 99.93% 99.94%
========================================
Files 67 68 +1
Lines 22982 23506 +524
========================================
+ Hits 22968 23492 +524
Misses 14 14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kartographer
force-pushed
the
uvcal_interp
branch
from
August 14, 2026 01:06
221f32a to
c95d879
Compare
bhazelton
reviewed
Aug 14, 2026
bhazelton
left a comment
Member
There was a problem hiding this comment.
This is a pretty major enhancement and looks super useful. I just have a few comments and questions.
4 tasks
kartographer
force-pushed
the
uvcal_interp
branch
from
August 18, 2026 00:45
4dc0e1c to
6958a74
Compare
bhazelton
approved these changes
Aug 18, 2026
bhazelton
left a comment
Member
There was a problem hiding this comment.
This looks good to me now, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A new method has been added to UVCal (
interpolate_in_time) that allows for calibration tables to be "upsampled", effectively allowing gains/delay measurements taken at one set of times to be interpolated/extrapolated to another set of times. Code associated with performing the interpolations has also been added to a new module,utils.gain_interpolation, which supports several different interpolation schemes, including nearest, linear, and cubic (PCHIP) interpolation strategies. An additional strategy -- "poly" -- allows for fitting the calibration solution with a variable-order Chebyshev polynomial and then performing interpolation/extrapolation using the fitted polynomial.A separate small change has been made to
uvcalibrate, which also allows users to reweightnsamples_arraybased on the amplitude calibration being applied todata_array.Motivation and Context
Higher frequency interferometers like the SMA frequently interleave observations of science targets with observations of bright quasars (or other point sources) that can act as gain calibrators for the data. Because those observations are disjoint in time with the observations of the "source", interpolation between the derived gain solutions is typically used to derive effective gains corrections during science target observations. This PR effectively provides that functionality, allowing
uvcalibrateto be used for SMA observations (among other facilities) .Types of changes
Checklist:
New feature checklist: