Skip to content

fix: retry HTTP download in install.ps1 on transient failure #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juhovainio wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −5
Open

fix: retry HTTP download in install.ps1 on transient failure #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,22 @@ function Save-File {
if ($PSVersionTable.PSVersion.Major -lt 6) {
$parameters.UseBasicParsing = $true
}
try {
Invoke-WebRequest @parameters
} catch {
Remove-Item -LiteralPath $OutputPath -Force -ErrorAction SilentlyContinue
Fail "${FailureMessage}: $($_.Exception.Message)"

# An HTTP transfer can fail transiently (a momentary connection reset, or
# the server-side listener still finishing setup) even though a retry a
# moment later succeeds; give it a couple of chances before giving up.
$maxAttempts = 3
for ($attempt = 1; $attempt -le $maxAttempts; $attempt++) {
try {
Invoke-WebRequest @parameters
return
} catch {
Remove-Item -LiteralPath $OutputPath -Force -ErrorAction SilentlyContinue
if ($attempt -eq $maxAttempts) {
Fail "${FailureMessage}: $($_.Exception.Message)"
}
Start-Sleep -Milliseconds (250 * $attempt)
}
}
}

Expand Down