Add weekly build workflow and CI fixes#575
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>
yansun1996
reviewed
Jun 15, 2026
Comment on lines
+4
to
+5
| push: | ||
| branches: [main] |
Member
There was a problem hiding this comment.
Since this workflow already runs on the cron schedule plus workflow_dispatch, the push: branches: [main] trigger also rebuilds on every merge to main — so a push and the weekly scheduled run can build in parallel. Is the per-push build intended (e.g. to validate each merge), or should this be dropped so the workflow stays purely scheduled/manual? Mainly want to check it doesn't overlap with the existing per-PR CI.
Collaborator
Author
There was a problem hiding this comment.
It should be dropped. I’ll fix it
yansun1996
suggested changes
Jun 15, 2026
Removed push trigger for main branch from weekly build workflow.
yansun1996
approved these changes
Jun 15, 2026
bhatnitish
approved these changes
Jun 15, 2026
bhatnitish
left a comment
Contributor
There was a problem hiding this comment.
LGTM — workflow is well-structured with a sensible skip-if-unchanged guard, TTY fix is straightforward, and adding docker-build-utils to all fills a gap. Looks good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add a weekly scheduled build workflow to automate recurring CI builds and fix TTY issues in the Makefile.
Technical Details
.github/workflows/weekly-build.yml: runs on a weekly schedule and manual dispatch, executes make targets inside a Docker containerMakefile: added-Tflag todocker runinvocations to handle non-TTY CI environmentsTest Plan
workflow_dispatchto verify the workflow runs correctlySubmission Checklist