Skip to content

Add weekly build workflow and CI fixes#575

Merged
sajmera-pensando merged 2 commits into
ROCm:mainfrom
spraveenio:main
Jun 15, 2026
Merged

Add weekly build workflow and CI fixes#575
sajmera-pensando merged 2 commits into
ROCm:mainfrom
spraveenio:main

Conversation

@spraveenio

Copy link
Copy Markdown
Collaborator

Motivation

Add a weekly scheduled build workflow to automate recurring CI builds and fix TTY issues in the Makefile.

Technical Details

  • Added .github/workflows/weekly-build.yml: runs on a weekly schedule and manual dispatch, executes make targets inside a Docker container
  • Updated Makefile: added -T flag to docker run invocations to handle non-TTY CI environments

Test Plan

  • Triggered manually via workflow_dispatch to verify the workflow runs correctly
  • Confirmed make targets execute successfully inside the container

Submission Checklist

Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>
Comment thread .github/workflows/weekly-build.yml Outdated
Comment on lines +4 to +5
push:
branches: [main]

@yansun1996 yansun1996 Jun 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this workflow already runs on the cron schedule plus workflow_dispatch, the push: branches: [main] trigger also rebuilds on every merge to main — so a push and the weekly scheduled run can build in parallel. Is the per-push build intended (e.g. to validate each merge), or should this be dropped so the workflow stays purely scheduled/manual? Mainly want to check it doesn't overlap with the existing per-PR CI.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be dropped. I’ll fix it

Removed push trigger for main branch from weekly build workflow.

@bhatnitish bhatnitish left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — workflow is well-structured with a sensible skip-if-unchanged guard, TTY fix is straightforward, and adding docker-build-utils to all fills a gap. Looks good to merge.

@sajmera-pensando sajmera-pensando merged commit 9388c15 into ROCm:main Jun 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants