gfx1250 mxfp8 gemm: loosen restrictions on K#627
Open
matthiasdiener wants to merge 2 commits into
Open
Conversation
matthiasdiener
requested review from
ipanfilo,
wangye805 and
wenchenvincent
as code owners
matthiasdiener
changed the title
| // Check that K is compatible with the MXFP8 scale layout, and M/N are multiples of 16 | ||
| if (inputA->scaling_mode == NVTE_MXFP8_1D_SCALING || inputB->scaling_mode == NVTE_MXFP8_1D_SCALING) { | ||
| const bool is_gfx1250 = cuda::sm_arch() == 125; | ||
| const int required_k_multiple = is_gfx1250 ? 32 : 128; |
Collaborator
There was a problem hiding this comment.
Add a TODO here to change this for gfx950 after scale preswizzle is in hipblasLt.
ipanfilo
requested changes
Jun 16, 2026
| } | ||
| if (params.k % 128) { | ||
| GTEST_SKIP() << "MXFP8 requires K to be a multiple of 128"; | ||
| const size_t required_k_multiple = (prop.major == 12 && prop.minor == 5) ? 32 : 128; |
Collaborator
There was a problem hiding this comment.
It should be under HIP_PLATFORM_AMD below
Contributor
Author
There was a problem hiding this comment.
What do you think of 3a7dd8f? Or do you prefer to move the whole if (use_mxfp8) part into the #ifdef __HIP_PLATFORM_AMD__ below?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Loosen restrictions on K on gfx1250 mxfp8 gemm (K must be multiple of 32), confirmed with hipblaslt developers.
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: