Add gfx1250 support to CK tile group GEMM#626
Open
aris134 wants to merge 3 commits into
Open
Conversation
aris134
requested review from
ipanfilo,
wangye805 and
wenchenvincent
as code owners
Comment on lines
+481
to
+484
| #if defined(__gfx942__) | ||
| case GPUArch::GFX942: | ||
| return ck_tile_grouped_gemm_fp8_dispatch_arch<GPUArch::GFX942>(a_dtype, b_dtype, d_dtype, ctx); | ||
| #endif |
Contributor
There was a problem hiding this comment.
Please re-check that these additional ifdefs are required.
Contributor
Author
There was a problem hiding this comment.
You're right, they are not. Fixed in 2cb357b
ipanfilo
requested changes
Jun 16, 2026
| bool need_k_pad, | ||
| const GroupedGemmRunContext& ctx) { | ||
| switch (detect_gpu_arch()) { | ||
| #if defined(__gfx942__) |
Collaborator
There was a problem hiding this comment.
It is device compile define, it should not be used in host code
|
|
||
| // Templated dispatch on A/B layouts, shared by all layout-specific .cpp files. | ||
| template <typename ALayout, typename BLayout> | ||
| template <GPUArch Arch, typename ALayout, typename BLayout> |
Collaborator
There was a problem hiding this comment.
For host code runtime arch detection should be used rather than building multiple template instances
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forwarding of #576 to dev with minor updates.
Fixes # (16490)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: