Fix for obtaining BLACS context. #5
Open
icosaeder wants to merge 1 commit into
Open
Conversation
…icated communicator, not just MPI_COMM_WORLD. After this fix, it is not needed to call eigen_init in every process anymore, but only in the participating ones, passing the appropriate communicator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it is needed to use EigenExa with a dedicated communicator, not just
MPI_COMM_WORLD. According to the documentation, the trick is to calleigen_initin each MPI process, supplying either the needed communicator for involved processes, orMPI_COMM_NULLfor the rest. However, it did not really work, as the BLACS context was always obtained from the default communicator. This pull request fixes that issue and improves the API so that there is no need to calleigen_initin every process anymore. It is enough to call it in the participating processes only, passing the appropriate communicator.Should this pull request be accepted, the EigenExa documentation should be amended accordingly. The change should be done in Section 3.2 of
EigenExa_Manual. In particular, the second paragraph of Section 3.2 ("Since a different communicator ... includingeigen_sx().") should be removed.