Skip to content

Reject out-of-range push_asset_amount in handle_funding #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xaudron wants to merge 1 commit into
base: rgb
Choose a base branch
from
+6 −1
Open

Reject out-of-range push_asset_amount in handle_funding #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lightning/src/rgb_utils/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,11 +664,16 @@ pub(crate) fn handle_funding(
_ => unreachable!("unsupported schema"),
};
let push_amount = push_asset_amount.unwrap_or(0);
let remote_rgb_amount = channel_rgb_amount.checked_sub(push_amount).ok_or_else(|| {
ChannelError::close(format!(
"push_asset_amount {push_amount} exceeds channel asset amount {channel_rgb_amount}"
))
})?;
let rgb_info = RgbInfo {
contract_id: consignment.contract_id(),
schema: AssetSchema::from_schema_id(consignment.schema_id()).unwrap(),
local_rgb_amount: push_amount,
remote_rgb_amount: channel_rgb_amount - push_amount,
remote_rgb_amount,
batch_transfer_idx: None,
// only meaningful on the initiator side, which is the one that sends media
counterparty_knows_asset: false,
Expand Down
Loading