Conversation
- Need to import everything again - Look how to use vars
|
@codex review this PR entirely, want to merge this! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d20db0318
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| YAMLS=$(find "$BASE_PATH" -name '*.yaml' | awk -F/ '{ print $NF }') | ||
| KUBECONFIG=$(fzf <<<"$YAMLS") | ||
| export KUBECONFIG=$BASE_PATH/$KUBECONFIG | ||
| printf 'export KUBECONFIG=%q\n' "$BASE_PATH/$KUBECONFIG" |
There was a problem hiding this comment.
The new selc_ script prints export KUBECONFIG=... instead of setting it, but zsh alias selc still uses source selc_; sourcing a script that only prints text does not update the shell environment. As a result, running selc no longer changes KUBECONFIG, breaking kubeconfig switching in interactive shells.
Useful? React with 👍 / 👎.
|
@codex review entriely again |
There was a problem hiding this comment.
💡 Codex Review
dotfiles/hosts/nixberry/default.nix
Line 10 in 9aa87b4
Remove the deleted shared-module import
For nixberry, this stale import now points at modules/nixos/default.nix, which this commit deletes while the other hosts were switched to rely on nixosModules from flake.nix. Evaluating nixosConfigurations.nixberry will therefore try to import a directory with no default.nix and fail before building.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…nt nixberry import (#46)
Co-authored-by: RAPSNX <mail@rapsn.me>
RAPSNX
changed the title
RAPSNX
changed the title
RAPSNX
changed the title
1 participant
Entire restructure