feat(protocol): add bounded plaintext OCF resource reads - #65
Open
Jason-Morcos wants to merge 1 commit into
Open
feat(protocol): add bounded plaintext OCF resource reads#65Jason-Morcos wants to merge 1 commit into
Jason-Morcos wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_plaintext_ocf_resource()for one known absolute href and public request port.Why
Some Family Hub responses span multiple Block2 packets and can arrive from a different UDP source port than the request port. Callers that need
/oic/d,/oic/res, or another public resource currently have to duplicate the token, source-pinning, continuation, and deadline logic already used by discovery.The latest hardware results in #16 also show why the response code needs to remain visible: a reachable endpoint or completed handshake does not imply that every resource is authorized. A complete 4.xx or 5.xx response is therefore returned as a complete non-success read, with its body intact.
Behavior
This branch is directly on
mainafter #48 and is independent of #49 and #50; it does not touchdtls_session.py.Validation
Related: #16